Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a condition to include or exclude the processing of nitrate depending on the model's output #768

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

zhanglikate
Copy link
Contributor

  1. Add a condition to include or exclude the processing of nitrate depending on the model's output
  2. Add XML control files and TXT files for UFS-Aerosols model output.

@zhanglikate
Copy link
Contributor Author

zhanglikate commented Aug 31, 2023 via email

@WenMeng-NOAA
Copy link
Collaborator

@zhanglikate You may add new aerosol fields in the files postcntrl_gefs_aerosol*. I am meaning:
in postcntrl_gefs_aerosol.xml:
Change
<gen_proc_type>ens_fcst</gen_proc_type>
into
<gen_proc_type>fcst</gen_proc_type>

change
     <gen_proc>gefs</gen_proc>
 into 
      <gen_proc>gfs_avn</gen_proc>

And the same changes for postcntrl_gefs_aerosol_f00.xml

@zhanglikate
Copy link
Contributor Author

zhanglikate commented Aug 31, 2023 via email

parm/postcntrl_gefs_aerosol_f00.xml
@zhanglikate
Copy link
Contributor Author

zhanglikate commented Aug 31, 2023 via email

@WenMeng-NOAA
Copy link
Collaborator

@zhanglikate and @lipan-NOAA Do you have UFS model output for the UPP standalone test? The files either on WCOSS2 or Hera would work for me.

@zhanglikate
Copy link
Contributor Author

@zhanglikate and @lipan-NOAA Do you have UFS model output for the UPP standalone test? The files either on WCOSS2 or Hera would work for me.

@WenMeng-NOAA This the model results at HERA: /scratch1/BMC/gsd-fv3-dev/lzhang/AODtest/case2

@WenMeng-NOAA
Copy link
Collaborator

@zhanglikate To generate GEFSV13 aerosol products in UPP, which option should I use in my test, gccpp_on, nasa_on, rdaod?

@zhanglikate
Copy link
Contributor Author

zhanglikate commented Sep 1, 2023 via email

@lipan-NOAA
Copy link
Contributor

example file => HPSS: /NCEPDEV/emc-naqfc/1year/Li.Pan/tmp/forkate-atmnc-upptest-20180808.htar & forkate-sfcnc-upptest-20180808.htar

@WenMeng-NOAA
Copy link
Collaborator

@zhanglikate You may add the following changes in parm/postcntrl_gefs_aerosol.xml and parm/postcntrl_gefs_aerosol_f00.xml to label ensemble products:

change
    <gen_proc_type>fcst</gen_proc_type>
into
   <gen_proc_type>ens_fcst</gen_proc_type>
change
    <gen_proc>gfs_avn</gen_proc>
into
   <gen_proc>gefs</gen_proc>
    

After update, the relevant txt files need to regenerated.

Revert postcntrl_gefs_aerosol.xml and postcntrl_gefs_aerosol_f00.xml
Update makefile to include UFS-Aerosols for GEFSv13
@zhanglikate
Copy link
Contributor Author

ens_fcst

@WenMeng-NOAA Finished. Can you check? Thanks.

@WenMeng-NOAA
Copy link
Collaborator

ens_fcst

@WenMeng-NOAA Finished. Can you check? Thanks.

@zhanglikate Your PR look good for me. I will run testing now. Thanks!

@WenMeng-NOAA
Copy link
Collaborator

@zhanglikate and @lipan-NOAA Do you know if the file parm/AEROSOL_LUTS.dat is used for processing UFS based aerosol data? If not, can we delete it?

@zhanglikate
Copy link
Contributor Author

zhanglikate commented Sep 8, 2023 via email

@WenMeng-NOAA
Copy link
Collaborator

@zhanglikate My test is at /scratch1/NCEPDEV/stmp2/Wen.Meng/post_gefs_2018080800 on Hera. Please let me know if you see any discrepancies with your test.

@lipan-NOAA
Copy link
Contributor

I tested it on WCOSS2, it looks fine for me

@WenMeng-NOAA
Copy link
Collaborator

I tested it on WCOSS2, it looks fine for me

@lipan-NOAA Can you provide me the model output files in netcdf from your test on WCOSS2?

@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. No Baseline Change No baseline of the UPP regression tests are made. labels Sep 12, 2023
@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RT on Hera and Orion. There should be updates in job scripts of gefs testing with aerosol fix file relocation. You may pick up my changes from

Hera: /scratch2/NCEPDEV/ovp/Wen.Meng/ncep_post/post_regression_test_new/jobs
         run_post_fv3gefs_HERA.sh and run_post_fv3gefs_pe_test_HERA.sh

Orion: /home/wmeng/ovp/ncep_post/post_regression_test_new/jobs
         run_post_fv3gefs_ORION.sh and run_post_fv3gefs_pe_test_ORION.sh

@WenMeng-NOAA
Copy link
Collaborator

The UPP RT was completed on WCOSS2 without changed results.

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RT on Hera and Orion. There should be updates in job scripts of gefs testing with aerosol fix file relocation. You may pick up my changes from

Hera: /scratch2/NCEPDEV/ovp/Wen.Meng/ncep_post/post_regression_test_new/jobs
         run_post_fv3gefs_HERA.sh and run_post_fv3gefs_pe_test_HERA.sh

Orion: /home/wmeng/ovp/ncep_post/post_regression_test_new/jobs
         run_post_fv3gefs_ORION.sh and run_post_fv3gefs_pe_test_ORION.sh

Apologies for the delay, I have RTs running on Hera and Orion. They've been temperamental today and dropping connection / freezing a lot from my side. I'll post results when they finish.

@FernandoAndrade-NOAA
Copy link
Collaborator

UPP RTs have completed successfully on Hera and Orion with no changes to results.

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 5cbcee6 into NOAA-EMC:develop Sep 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GEFSV13 No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude nitrate in calculating Total AOD for UFS-Aerosols model (option: nasa_on) and update control files
4 participants