Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop]: Update most remaining documentation files #737

Merged
merged 48 commits into from
Jul 21, 2023

Conversation

gspetro-NOAA
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA commented Jun 30, 2023

This PR updates documentation in the following files:

  • docs/Doxyfile.in --> Removed deprecated entries to avoid warnings
  • CALHEL2.f
  • CALHEL3.f
  • CALMICT.f
  • CALPBL.f
  • CALPBLREGIME.f
  • CALPW.f
  • CALRAD_WCLOUD_newcrtm.f
  • CLDRAD.f
  • COLLECT.f
  • COLLECT_LOC.f
  • CTLBLK.f
  • EXCH.f
  • FDLVL.f
  • GFIP3.f
  • GPVS.f
  • GRIDSPEC.f
  • INITPOST_GFS_NEMS_MPIIO.f
  • INITPOST_NEMS.f
  • INITPOST_NETCDF.f
  • MDL2P.f
  • MPI_FIRST.f
  • PMICRPH.f
  • PROCESS.f
  • SELECT_CHANNELS.f
  • SMOOTH.f
  • WRFPOST.f
  • xml_perl_data.f

This PR largely addresses Issue #392 . Some final testing and perhaps another small PR may be required before WARN_ON_ERROR can be turned on.

Warnings have been silenced for CALRAD_WCLOUD_newcrtm.f, CLDRAD.f, COLLECT_LOC.f, CTLBLK.f, GPVS.f, and MPI_FIRST.f even though a few variables or subroutines in each are awaiting a definition. Those will be added at a later date when EMC is able to provide that information.

@gspetro-NOAA gspetro-NOAA added the documentation Improvements or additions to documentation label Jul 14, 2023
@gspetro-NOAA gspetro-NOAA marked this pull request as ready for review July 14, 2023 22:14
@gspetro-NOAA gspetro-NOAA changed the title [develop]: Update all remaining documentation files [develop]: Update most remaining documentation files Jul 18, 2023
@FernandoAndrade-NOAA
Copy link
Collaborator

Hi @gspetro-NOAA, could you sync up your branch with develop? I'll go ahead and get started with RTs on Hera afterwards, thanks!

@gspetro-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA Just sync'd it! Was out yesterday--sorry for the delay!

@FernandoAndrade-NOAA
Copy link
Collaborator

@WenMeng-NOAA UPP RTs for this PR have finished successfully on Hera with no changes to results.
Run is available at /scratch1/NCEPDEV/nems/Fernando.Andrade-maldonado/regression-tests/upp-tests/emc/rt-737/

@WenMeng-NOAA
Copy link
Collaborator

@WenMeng-NOAA UPP RTs for this PR have finished successfully on Hera with no changes to results. Run is available at /scratch1/NCEPDEV/nems/Fernando.Andrade-maldonado/regression-tests/upp-tests/emc/rt-737/

@FernandoAndrade-NOAA Your testing looks good to me. You may go ahead to approve this PR.

@WenMeng-NOAA
Copy link
Collaborator

The UPP RT tests were completed on WCOSS2 and Orion without changed results. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA added No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. labels Jul 21, 2023
@WenMeng-NOAA WenMeng-NOAA merged commit 54cf351 into NOAA-EMC:develop Jul 21, 2023
FernandoAndrade-NOAA pushed a commit that referenced this pull request Aug 9, 2023
* add CTLBLK html

* add CALMICT htmls

* add CALPBL/CALPBLREGIME htmls

* add CALPW, CALRAD_WCLOUD_newcrtm, and CLDRAD htmls

* add COLLECT and COLLECT_LOC htmls

* update EXCH & FDLVL htmls

* update GFIP3, GPVS, and GRIDSPEC htmls

* update INITPOST* htmls

* update MDL2P, MPI_FIRST, & PMICRPH

* update PROCESS & WRFPOST files

* update xml_perl_data html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants