Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for several UPP files #696

Merged
merged 41 commits into from
Apr 26, 2023
Merged

Update documentation for several UPP files #696

merged 41 commits into from
Apr 26, 2023

Conversation

gspetro-NOAA
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA commented Apr 24, 2023 •
edited
Loading

This PR updates documentation in the following files:

  • CTLBLK.f (will need a second round of updates)
  • DEWPOINT.f
  • EXCH_c_float.f
  • FILL_PSETFLD.f
  • FRZLVL.f
  • FRZLVL2.f
  • GET_BITS.f
  • GFIP3.f
  • GFSPOST.F
  • LFMFLD.f
  • LFMFLD_GFS.f
  • MDL2STD_P.f
  • MDL2THANDPV.f
  • PARA_RANGE.f
  • SCLFLD.f
  • SELECT_CHANNELS.f
  • SMOOTH.f
  • SURFACE.f
  • UPP_MATH.f
  • UPP_PHYSICS.f
  • kinds_mod.F
  • native_endianness.f
  • retrieve_index.f

This PR partially addresses Issue #392 .

gspetro and others added 30 commits April 11, 2023 10:55
@gspetro
update upp_math to remove warnings
bbb3e3d
@gspetro
document members of kinds_mod.F
443165c
@gspetro-NOAA
Merge branch 'NOAA-EMC:develop' into text/dox8.1a
0cebd80
@gspetro
document members/return vals for native_endianness.f
9ed3023
@gspetro
basic documentation of GFIP3.f to remove warnings
baa5acd
@gspetro
silence warnings for CTLBLK.f
77301ce
@gspetro
eliminate warnings for GET_BITS.f
cc89615
@gspetro
switch SURFCE.f comments to fortran & silence warnings
4219b7b
@gspetro
silence warnings for FRZLVL.f and FRZLVL2.f
e968625
@gspetro
silence warnings on SMOOTH.f
1520cf4
@gspetro
silence warnings on SELECT_CHANNELS.f
79fc650
@gspetro
silence warnings on SCLFLD.f
5eb4e1d
@gspetro
silence warnings for retrieve_index.f
6673321
@gspetro
silence warnings on PARA_RANGE.f
06165c0
@gspetro
silence warnings on GFSPOST.F
5d04afd
@gspetro-NOAA
Merge branch 'NOAA-EMC:develop' into text/dox8.1a
2d2b43a
@gspetro
silence warnings on LFMFLD.f
08afe2b
@gspetro
Merge branch 'text/dox8.1a' of github.com:gspetro-NOAA/UPP into text/…
9651243 
…dox8.1a
@gspetro
silence warnings on FILL_PSETFLD.f
cf9ce9e
@gspetro
silence warnings on EXCH_c_float.f
2c59df7
@gspetro
silence warnings on DEWPOINT.f
1a24b8d
@gspetro
update MDL2THANDPV.f
15ed71a
@gspetro
updates to UPP_MATH.f and MDL2THANDPV.f
37f3cb7
@gspetro
update kinds_mod.F
3366fb2
@gspetro
update native_endianness.f
54ab301
@gspetro
silence warnings on UPP_PHYSICS.f
112ed03
@gspetro
update MDL2STD_P.f
4f875a7
@gspetro
update GET_BITS.f
4ca641a
@gspetro
supress GFIP3.f warnings; update var defs
c9f9432
@gspetro
update var defs in GFIP3.f
9ae1673
@gspetro-NOAA gspetro-NOAA marked this pull request as ready for review April 24, 2023 20:09
fossell
fossell approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@fossell fossell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates to doxygen look good. @gspetro-NOAA - were you wanting to pull out CTLBLK since it requires more work or keep these header updates and continue work that routine for a separate PR?

@fossell
Copy link
Contributor

fossell commented Apr 25, 2023

Updates to doxygen look good. @gspetro-NOAA - were you wanting to pull out CTLBLK since it requires more work or keep these header updates and continue work that routine for a separate PR?

@gspetro-NOAA - Nevermind, I see your comment in the PR now regarding CTLBLK. I overlooked that! Sounds like a plan, my approval still stands.

@WenMeng-NOAA
Copy link
Collaborator

@gspetro-NOAA Is your branch ready for testing?

@gspetro-NOAA
Copy link
Collaborator Author

@WenMeng-NOAA Yes! Thanks :)

hertneky
hertneky suggested changes Apr 25, 2023
View reviewed changes
sorc/ncep_post.fd/GFSPOST.F Outdated Show resolved Hide resolved
sorc/ncep_post.fd/GFSPOST.F Outdated Show resolved Hide resolved
@WenMeng-NOAA WenMeng-NOAA added the documentation Improvements or additions to documentation label Apr 25, 2023
@WenMeng-NOAA
Copy link
Collaborator

@fossell @hertneky Thanks for reviewing this PR.

@WenMeng-NOAA
Copy link
Collaborator

The UPP RT tests were completed on WCOSS2, Hera and Orion. No baseline update is needed with this PR. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. No Baseline Change No baseline of the UPP regression tests are made. labels Apr 26, 2023
@WenMeng-NOAA WenMeng-NOAA merged commit a5078ea into NOAA-EMC:develop Apr 26, 2023
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Apr 26, 2023
Closed
gspetro-NOAA added a commit to gspetro-NOAA/UPP that referenced this pull request Apr 27, 2023
@gspetro-NOAA
add htmls for files updated in PR NOAA-EMC#696
98a6581
@gspetro-NOAA gspetro-NOAA mentioned this pull request Apr 27, 2023
Merged
gspetro-NOAA added a commit to gspetro-NOAA/UPP that referenced this pull request Apr 27, 2023
@gspetro-NOAA
add remaining htmls for files updated in PR NOAA-EMC#696
be5aa9e
gspetro-NOAA added a commit that referenced this pull request Apr 28, 2023
@gspetro-NOAA
Merge pull request #697 from gspetro-NOAA/text/gh-pages
f6f806f 
Add htmls for files updated in PR #696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

@hertneky hertneky hertneky approved these changes

@fossell fossell fossell approved these changes

@kayeekayee kayeekayee Awaiting requested review from kayeekayee

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gspetro-NOAA @fossell @WenMeng-NOAA @hertneky @gspetro