Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for MSFPS.f, NGMFLD.f, OTLFT.f, OTLIFT.f, and ZENSUN.f #681

Merged
merged 11 commits into from
Apr 3, 2023

Conversation

gspetro-NOAA
Copy link
Collaborator

This PR updates MSFPS.f, NGMFLD.f, OTLFT.f, OTLIFT.f (which require documentation of each subroutine even when the same information appears in the file description above), and ZENSUN.f (which needed a definition for the variable pi).

This PR partially addresses Issue #392 .

@gspetro-NOAA gspetro-NOAA marked this pull request as ready for review April 1, 2023 04:31
Copy link
Contributor

@fossell fossell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are to doxygen comments/synax and look good to me.

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA Could you conduct the UPP RT test on either Hera or Orion? Since this PR is for documentation updating, one platform testing should be fine.

@WenMeng-NOAA WenMeng-NOAA added documentation Improvements or additions to documentation Ready for Review This PR is ready for code review. labels Apr 3, 2023
@FernandoAndrade-NOAA
Copy link
Collaborator

@WenMeng-NOAA UPP RT tests completed on Hera with no change to results.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Apr 3, 2023
@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants