-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for variables in CALGUST.f and CALHEL.f #630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Documentation updates only, no change to code.
@gspetro-NOAA - Looks good to me. Please wait for @WenMeng-NOAA to review and approve and give the ago ahead for merging. |
@gspetro-NOAA Your PR will be the next one being processed. Can you make it up to date with develop branch? The syncing procedures can be found at |
Done! :) Let me know if you need anything else.
I believe I will need to issue a PR to the gh-pages branch with the updated
html files once this is merged, so keep an eye out for that.
Best,
Gillian
…On Tue, Feb 14, 2023 at 8:35 AM WenMeng-NOAA ***@***.***> wrote:
@gspetro-NOAA <https://github.com/gspetro-NOAA> Your PR will be the next
one being processed. Can you make it up to date with develop branch? The
syncing procedures can be found at
https://github.com/NOAA-EMC/UPP/wiki/UPP-Code-Development#update-your-branch-at-your-fork-with-branch-develop-at-authoritative-repository
—
Reply to this email directly, view it on GitHub
<#630 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXDGAE3533AEKLDWIKXVAE3WXOCYHANCNFSM6AAAAAAUYCF374>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The UPP RT tests were completed on WCOSS2. No baseline change is needed with this PR. This PR is ready for merging. |
This PR provides a definition for the LPBL and ZPBL variables in CALGUST.f
It also corrects a typo in CALHEL.f that generated a warning (DPTH --> should be DEPTH).
This partially addresses Issue #392 .