Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for variables in CALGUST.f and CALHEL.f #630

Merged
merged 5 commits into from
Feb 14, 2023

Conversation

gspetro-NOAA
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA commented Feb 10, 2023

This PR provides a definition for the LPBL and ZPBL variables in CALGUST.f
It also corrects a typo in CALHEL.f that generated a warning (DPTH --> should be DEPTH).

This partially addresses Issue #392 .

@fossell fossell self-requested a review February 11, 2023 20:23
Copy link
Contributor

@fossell fossell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Documentation updates only, no change to code.

@fossell
Copy link
Contributor

fossell commented Feb 13, 2023

@gspetro-NOAA - Looks good to me. Please wait for @WenMeng-NOAA to review and approve and give the ago ahead for merging.

@WenMeng-NOAA
Copy link
Collaborator

@gspetro-NOAA Your PR will be the next one being processed. Can you make it up to date with develop branch? The syncing procedures can be found at
https://github.com/NOAA-EMC/UPP/wiki/UPP-Code-Development#update-your-branch-at-your-fork-with-branch-develop-at-authoritative-repository

@gspetro-NOAA
Copy link
Collaborator Author

gspetro-NOAA commented Feb 14, 2023 via email

@WenMeng-NOAA WenMeng-NOAA added documentation Improvements or additions to documentation Ready for Review This PR is ready for code review. labels Feb 14, 2023
@WenMeng-NOAA
Copy link
Collaborator

The UPP RT tests were completed on WCOSS2. No baseline change is needed with this PR. This PR is ready for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants