release/public-v2: fix problem linking to static NetCDF libraries #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st static NetCDF libraries
climbfuji
requested review from
WenMeng-NOAA,
DusanJovic-NOAA,
fossell and
mkavulich
DusanJovic-NOAA
approved these changes
Oct 7, 2020
fossell
approved these changes
Oct 7, 2020
|
@climbfuji - Approved. Please merge when you're ready. |
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
## DESCRIPTION OF CHANGES: * In setup.sh and generate_FV3LAM_wflow.sh, remove temporary codes that fix bugs in the FV3_GFS_2017_gfdlmp_regional suite definition file because those bugs have been fixed (in the ufs-weather-model repo). * In setup.sh, remove block of code that is no longer necessary because chgres_cube can now initialize from external model data with either 4 or 9 soil levels, and run with LSMs of either 4 or 9 soil levels. * Remove modifications to LD_LIBRARY_PATH in exregional_run_fcst.sh. * For the make_ics and make_lbcs tasks, move the setting of APRUN and other machine-specific actions from the J-job to the ex-script in order to be consistent with the other workflow tasks. * Fix indentation and edit comments. * Remove unused file load_fv3gfs_modules.sh. ## TESTS CONDUCTED: Ran two WE2E tests on hera, new_ESGgrid and new_GFDLgrid: * new_ESGgrid uses the FV3_GFS_2017_gfdlmp_regional suite. The test was successful. * new_GFDLgrid uses the FV3_GFS_2017_gfdlmp suite. The test was successful. ## ISSUE (optional): This resolves issue NOAA-EMC#198.
EricJames-NOAA
added a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
…o point to updated 65-level fixed file. (NOAA-EMC#198)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the submodule pointer for CMakeModules to fix a problem when linking against static NetCDF libraries.
The issue is that the NetCDF C library is not added automatically to the NetCDF Fortran imported target by the current
FindNetCDF.cmakemacro. @DusanJovic-NOAA fixed this recently in CMakeModules, see NOAA-EMC/CMakeModules#42. The solution is to simply forward the submodule pointer to the current head of develop of CMakeModules (hash 8aaef34fa720212cf14fe50e3f959ac8036bf388).This has been tested on Cheyenne with the Intel compiler, using the NCEPLIBS-ufs-v2.0.0 installation (which has static NetCDF libraries only).