Unify the public-v2 executable name #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consistent with other applications
fossell
requested review from
aerorahul,
climbfuji,
JeffBeck-NOAA and
DusanJovic-NOAA
and removed request for
aerorahul
aerorahul
approved these changes
Oct 6, 2020
DusanJovic-NOAA
approved these changes
Oct 6, 2020
|
@mkavulich - Could you please confirm this mod is ok since you're currently working on the merge of cmake build for SRW? Just want to make sure this is ok with SRW workflow and any necessary mods to executable name on SRW end are addressed. |
This was referenced Oct 20, 2020
Closed
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the public-v2 executable name from nceppost.x --> ncep_post to be consistent across applications (MRW, EMC operations, community standalone, SRW). Note that this naming convention is slated to be reviewed and potentially changed again in the future. Consistency now will make that future step cleaner.