Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge gsd upp #159

Merged
merged 11 commits into from
Aug 24, 2020
Merged

Merge gsd upp #159

merged 11 commits into from
Aug 24, 2020

Conversation

WenMeng-NOAA
Copy link
Collaborator

Incorporate the changes of rapv5/hrrr4 from GSD UPP repository on VLAB:

  1. new or modified GSD algorithms in source code;
  2. new fields in params_grib2_tbl_new;
  3. post_avblflds_raphrrr.xml, and control files for hrrr and rap;
  4. clean some legacy control files for hrrr and rap.

@WenMeng-NOAA WenMeng-NOAA linked an issue Aug 10, 2020 that may be closed by this pull request
Merge gsd UPP #158
Closed
@WenMeng-NOAA
Copy link
Collaborator Author

@hu5970 and @jaymes-kenyon Please review the code and let me know anything is missing or incorrect. Thanks!

jaymes-kenyon
jaymes-kenyon reviewed Aug 17, 2020
View reviewed changes
Copy link
Contributor

@jaymes-kenyon jaymes-kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Wen. It's a very large merge, so I'd like Ming to review this, also. Thanks for your work here!

@WenMeng-NOAA
Copy link
Collaborator Author

The UPP regression tests for GFS, GEFS, NMMB, FV3SAR and HAFS were conducted on Dell and Hera. No changed results were found. New baselines for HRRR and RAP were created. It was found that cloud base height and pressure were not reproducible with changing MPI tasks. But these two fields will not have an impact on other application processing. The bug fix would be added in the future. This branch post_gsd is ready for merging.

@WenMeng-NOAA
Copy link
Collaborator Author

Re-create the regression baselines for NMMB, HRRR, RAP.

@WenMeng-NOAA WenMeng-NOAA merged commit 2a5aab0 into NOAA-EMC:develop Aug 24, 2020
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Aug 24, 2020
Closed
@WenMeng-NOAA WenMeng-NOAA deleted the post_gsd branch June 9, 2021 14:48
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
@JeffBeck-NOAA
Merge pull request NOAA-EMC#159 from JeffBeck-NOAA/community_develop
1aad625 
Change to grib2 parameter file for UPP
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
@christinaholtNOAA
RRFS_dev1: Expanding resources for real-time graphics. (NOAA-EMC#159)
a61fea0 
* Expanding resources for real-time graphics.

* More partitions for NA domains, too.

* More partitions for AK.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymes-kenyon jaymes-kenyon jaymes-kenyon left review comments

@hu5970 hu5970 hu5970 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge gsd UPP
3 participants
@WenMeng-NOAA @hu5970 @jaymes-kenyon