Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pointer to CMakeModules #156

Merged
merged 1 commit into from
Aug 4, 2020
Merged

update pointer to CMakeModules #156

merged 1 commit into from
Aug 4, 2020

Conversation

aerorahul
Copy link
Contributor

update pointer to CMakeModules following CMakeModules PR 40

@aerorahul aerorahul requested review from climbfuji and fossell July 31, 2020 02:02
@fossell
Copy link
Contributor

fossell commented Jul 31, 2020

Is this change also need for SRW app v1.0 (release/public-v2 branch)? Or is this purely development?

@climbfuji
Copy link
Contributor

Is this change also need for SRW app v1.0 (release/public-v2 branch)? Or is this purely development?

I can tell you that it is not needed for MRW app v1.1 (release/public-v1) - I can't tell you right away if it should go into release/public-v2. I hope it will, though.

@WenMeng-NOAA
Copy link
Collaborator

@fossell and @aerorahul I might think this #PR is an update of CAMKE build capacity, will have no impact on GNC build and change the UPP regression tests, right?

@aerorahul
Copy link
Contributor Author

@WenMeng-NOAA
This PR does not impact GNU builds.
This PR is an update to the cleanup from @climbfuji

@WenMeng-NOAA
Copy link
Collaborator

@aerorahul Thanks for clarifying. I might wait for @fossell's reviewing.

@fossell
Copy link
Contributor

fossell commented Aug 4, 2020

All - apologies for delayed response, had other project priorities to address. This is ok with me, I'll work with SRW team as needed to see if they will need this for their build.

@WenMeng-NOAA
Copy link
Collaborator

@fossell Thanks for confirming. I will proceed merging in branch develop.

@WenMeng-NOAA WenMeng-NOAA merged commit 688c425 into develop Aug 4, 2020
@fossell fossell mentioned this pull request Aug 4, 2020
Closed
@aerorahul aerorahul deleted the feature/update-CMakeModules branch June 27, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fossell fossell fossell approved these changes

@climbfuji climbfuji climbfuji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aerorahul @fossell @climbfuji @WenMeng-NOAA