Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAILCAST fix #1154

Merged
merged 2 commits into from
Mar 1, 2025
Merged

Conversation

EricJames-NOAA
Copy link
Contributor

Adding a check for undefined values before assigning hailcast in RRFS output.

The code was tested for a RRFS_CONUS_3km case on Jet.

@WenMeng-NOAA WenMeng-NOAA linked an issue Feb 28, 2025 that may be closed by this pull request
@WenMeng-NOAA WenMeng-NOAA added RRFS Ready for Review This PR is ready for code review. labels Feb 28, 2025
@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA I conducted the following two tests with RRFS data at /home/Wen.Meng/stmp2 on Hera:
before: rfs_2022022412-before
after: post_rrfs_2022022412-after
There are changes in HAIL as:

1351:7061616753:ndata=14452641:undef=0:mean=1.50558e+17:min=0:max=9.99e+17:cos_wt_mean=1.77815e+17
into
1351:7061616753:ndata=14452641:undef=2178132:mean=6.92362e-07:min=0:max=0.0421:cos_wt_mean=9.83156e-07

Please let me know if you see issues in my tests.

@EricJames-NOAA
Copy link
Contributor Author

@EricJames-NOAA I conducted the following two tests with RRFS data at /home/Wen.Meng/stmp2 on Hera: before: rfs_2022022412-before after: post_rrfs_2022022412-after There are changes in HAIL as:

1351:7061616753:ndata=14452641:undef=0:mean=1.50558e+17:min=0:max=9.99e+17:cos_wt_mean=1.77815e+17
into
1351:7061616753:ndata=14452641:undef=2178132:mean=6.92362e-07:min=0:max=0.0421:cos_wt_mean=9.83156e-07

Please let me know if you see issues in my tests.

@WenMeng-NOAA that looks good to me. I had similar results (for a different case).

@WenMeng-NOAA
Copy link
Collaborator

No UPP RTs are needed for this PR.

@WenMeng-NOAA WenMeng-NOAA merged commit d62984b into NOAA-EMC:release/rrfs_v1 Mar 1, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HAILCAST output in RRFSv1 is all zero
2 participants