Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gefs control files with adding ICEG and moving aerosol fields #1153

Merged
merged 6 commits into from
Feb 28, 2025
Merged

Update gefs control files with adding ICEG and moving aerosol fields #1153

merged 6 commits into from
Feb 28, 2025

Conversation

WenMeng-NOAA
Copy link
Collaborator

This PR is for addressing issue #1147 and #1152.

This was linked to issues Feb 27, 2025
Request for GEFS v13 to produce freezing spray to help a OPC's milestone #1147
Closed
Removing aerosol fields from gefs control files #1152
Closed
EricSinsky-NOAA
EricSinsky-NOAA approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@EricSinsky-NOAA EricSinsky-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for adding ICEG and moving the aerosol fields from GEFS.

@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Feb 27, 2025
@WenMeng-NOAA
Copy link
Collaborator Author

@EricSinsky-NOAA Please look at my UPP standalone test for gefs results at /u/wen.meng/ptmp/post_gefs_2023080300 on cactus:

wen.meng@clogin09 post_gefs_2023080300$ wgrib2 GFSPRS.GrbF09 -match ICEG
394:316230580:d=2023080300:ICEG:10 m above mean sea level:9 hour fcst:ENS=+1

ICEG was successfully generated.

@WenMeng-NOAA
Copy link
Collaborator Author

@lipan-NOAA Please look at my UPP standalone test with gefs model output and new gcafs control file at /u/wen.meng/ptmp/post_gcafs_2023080300 on Cactus.

@WenMeng-NOAA
Copy link
Collaborator Author

@gspetro-NOAA This PR is ready for the UPP RTs on R&D machines. There should be baseline changes.

@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RTs have been completed on WCOSS2 with no baseline changes.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Feb 27, 2025
gspetro-NOAA
gspetro-NOAA approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTs pass on Hera, Orion, and Hercules w/no baseline changes. nmmb_* tests run a little long on Hera compared to the baseline and previous nmmb tests on Hera. Worth keeping an eye on to make sure that time doesn't continue to grow.

@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit c6f039b into NOAA-EMC:develop Feb 28, 2025
3 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Feb 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lipan-NOAA lipan-NOAA lipan-NOAA approved these changes

@EricSinsky-NOAA EricSinsky-NOAA EricSinsky-NOAA approved these changes

@gspetro-NOAA gspetro-NOAA gspetro-NOAA approved these changes

@ChristopherHill-NOAA ChristopherHill-NOAA Awaiting requested review from ChristopherHill-NOAA

@BenjaminBlake-NOAA BenjaminBlake-NOAA Awaiting requested review from BenjaminBlake-NOAA

Assignees
No one assigned
Labels
GEFSV13 No Baseline Change No baseline of the UPP regression tests are made. Ready for commit queue Ready for Review This PR is ready for code review.
Projects
None yet
Milestone
No milestone
4 participants
@WenMeng-NOAA @lipan-NOAA @EricSinsky-NOAA @gspetro-NOAA