Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename shortname for ID 1021 and 1022 #1115

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

WenMeng-NOAA
Copy link
Collaborator

Solve issue #1114.

@WenMeng-NOAA WenMeng-NOAA added bug Something isn't working SFSV1 labels Jan 21, 2025
@WenMeng-NOAA WenMeng-NOAA linked an issue Jan 21, 2025 that may be closed by this pull request
@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Jan 21, 2025
@WenMeng-NOAA
Copy link
Collaborator Author

@JesseMeng-NOAA From my UPP test for SFS at /u/wen.meng/ptmp/post_sfs_2022090100 on Cactus, there are no changes in the results.

@WenMeng-NOAA
Copy link
Collaborator Author

@gspetro-NOAA This PR is ready for the UPP RTs on R&D machines.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Jan 21, 2025
@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RTs have been completed on WCOSS2 with no baseline changes.

@gspetro-NOAA
Copy link
Collaborator

@WenMeng-NOAA @FernandoAndrade-NOAA The tests pass on all systems without baseline changes, but on Orion, I'm seeing a bunch of warnings in the log files like this:

Lmod Warning: Syntax error in file:
/apps/contrib/spack-stack/spack-stack-1.8.0/envs/ue-intel-2021.9.0/install/modulefiles/intel/2021.9.0/stack-intel-oneapi-mpi/2021.9.0.lua
 with command: setenv, one or more arguments are not strings.

While processing the following module(s):
    Module fullname                  Module Filename
    ---------------                  ---------------
    stack-intel-oneapi-mpi/2021.9.0  /apps/contrib/spack-stack/spack-stack-1.8.0/envs/ue-intel-2021.9.0/install/modulefiles/intel/2021.9.0/stack-intel-oneapi-mpi/2021.9.0.lua

Not sure what could be causing it, but I might run the RTs on Orion again and see if it was a fluke unless @FernandoAndrade-NOAA has some idea of what might be causing that?

@FernandoAndrade-NOAA
Copy link
Collaborator

@WenMeng-NOAA @FernandoAndrade-NOAA The tests pass on all systems without baseline changes, but on Orion, I'm seeing a bunch of warnings in the log files like this:

Lmod Warning: Syntax error in file:
/apps/contrib/spack-stack/spack-stack-1.8.0/envs/ue-intel-2021.9.0/install/modulefiles/intel/2021.9.0/stack-intel-oneapi-mpi/2021.9.0.lua
 with command: setenv, one or more arguments are not strings.

While processing the following module(s):
    Module fullname                  Module Filename
    ---------------                  ---------------
    stack-intel-oneapi-mpi/2021.9.0  /apps/contrib/spack-stack/spack-stack-1.8.0/envs/ue-intel-2021.9.0/install/modulefiles/intel/2021.9.0/stack-intel-oneapi-mpi/2021.9.0.lua

Not sure what could be causing it, but I might run the RTs on Orion again and see if it was a fluke unless @FernandoAndrade-NOAA has some idea of what might be causing that?

I've only seen that pop up once, but it seems to have an issue with one of the setenv() arguments within the specified .lua file ending up as a null value, I'm not sure who we would check with on this. It seems inconsistent, the current jenkins RT run on orion doesnt seem to be printing that out in the logs.

@gspetro-NOAA
Copy link
Collaborator

No luck on the rerun. Still getting the same errors in the Orion log file, so I'll have to look in more detail tomorrow.

Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTs pass on Hera, Orion, and Hercules w/no baseline changes.

@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 53c7862 into NOAA-EMC:develop Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working No Baseline Change No baseline of the UPP regression tests are made. Ready for commit queue Ready for Review This PR is ready for code review. SFSV1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicted UPP Short Names
4 participants