Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gefs inline post itag file #1060

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Add gefs inline post itag file #1060

merged 6 commits into from
Oct 9, 2024

Conversation

WenMeng-NOAA
Copy link
Collaborator

Main changes include:

  • Add gefs inline post itag file
  • Update gfs inline post itag files

This was linked to issues Oct 8, 2024
Add itag file for GEFS inline post #1059
Closed
Update gfs inline post itag files #1061
Closed
@WenMeng-NOAA WenMeng-NOAA requested a review from aerorahul October 8, 2024 14:46
@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Oct 8, 2024
aerorahul
aerorahul reviewed Oct 8, 2024
View reviewed changes
parm/gefs/post_itag_gefs Outdated Show resolved Hide resolved
aerorahul
aerorahul approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Oct 8, 2024
@WenMeng-NOAA
Copy link
Collaborator Author

@gspetro-NOAA @FernandoAndrade-NOAA You may start the UPP RTs on R&D machines. There should be no baseline changes with this PR.

@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RTs have been completed on WCOSS2 without baseline changes.

@WenMeng-NOAA
Copy link
Collaborator Author

@gspetro-NOAA Thanks for testing on R&D machines. Please go ahead to approve this PR.

gspetro-NOAA
gspetro-NOAA approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RTs passed on Hera, Orion, and Hercules with no baseline change.

@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 72108ee into NOAA-EMC:develop Oct 9, 2024
3 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Oct 9, 2024
Open
@NickSzapiro-NOAA NickSzapiro-NOAA mentioned this pull request Oct 30, 2024
Draft
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspetro-NOAA gspetro-NOAA gspetro-NOAA approved these changes

@aerorahul aerorahul aerorahul approved these changes

@FernandoAndrade-NOAA FernandoAndrade-NOAA Awaiting requested review from FernandoAndrade-NOAA

Assignees
No one assigned
Labels
GEFSV13 GFSV17 No Baseline Change No baseline of the UPP regression tests are made. Ready for commit queue Ready for Review This PR is ready for code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update gfs inline post itag files Add itag file for GEFS inline post
3 participants
@WenMeng-NOAA @aerorahul @gspetro-NOAA