Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RRFS-MPAS: Provide TSOIL and SOILW (9 levels) in native-level GRIB2 files #1054

Merged
merged 7 commits into from
Oct 3, 2024
Merged

RRFS-MPAS: Provide TSOIL and SOILW (9 levels) in native-level GRIB2 files #1054

merged 7 commits into from
Oct 3, 2024

Conversation

jaymes-kenyon
Copy link
Contributor

For RRFS-MPAS applications, this update provides TSOIL and SOILW within the native-level GRIB2 files for all nine soil levels. It has been successfully tested in a real-time RRFS-MPAS configuration.

This PR addresses issue #1053.

@jaymes-kenyon
Updating RRFS-MPAS control file to include TSOIL and SOILW (nine leve…
3f4ce55 
…ls) within both the pressure- and native-level GRIB2 files.
@jaymes-kenyon jaymes-kenyon marked this pull request as ready for review September 26, 2024 17:16
@WenMeng-NOAA WenMeng-NOAA linked an issue Sep 26, 2024 that may be closed by this pull request
RRFS-MPAS: TSOIL and SOILW needed in native-level GRIB2 files #1053
Closed
@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon Please validate my UPP standalone test at /home/Wen.Meng/stmp2/mpas_2024082112 on Hera.
I see new fields added in the dataset WRFNAT as:

Wen.Meng@hfe02 mpas_2024082112$ wgrib2 WRFNAT12.tm00 -match TSOIL
1004:572666045:d=2024082100:TSOIL:0-0 m below ground:12 hour fcst:
1006:575599968:d=2024082100:TSOIL:0.01-0.01 m below ground:12 hour fcst:
1008:578401926:d=2024082100:TSOIL:0.04-0.04 m below ground:12 hour fcst:
1010:581131012:d=2024082100:TSOIL:0.1-0.1 m below ground:12 hour fcst:
1012:583799560:d=2024082100:TSOIL:0.3-0.3 m below ground:12 hour fcst:
1014:586353377:d=2024082100:TSOIL:0.6-0.6 m below ground:12 hour fcst:
1016:588861504:d=2024082100:TSOIL:1-1 m below ground:12 hour fcst:
1018:591355880:d=2024082100:TSOIL:1.6-1.6 m below ground:12 hour fcst:
1020:593884099:d=2024082100:TSOIL:3-3 m below ground:12 hour fcst:

Wen.Meng@hfe02 mpas_2024082112$ wgrib2 WRFNAT12.tm00 -match SOILW
1009:580165320:d=2024082100:SOILW:0.04-0.04 m below ground:12 hour fcst:
1011:582875577:d=2024082100:SOILW:0.1-0.1 m below ground:12 hour fcst:
1013:585465416:d=2024082100:SOILW:0.3-0.3 m below ground:12 hour fcst:
1015:587967861:d=2024082100:SOILW:0.6-0.6 m below ground:12 hour fcst:
1017:590486621:d=2024082100:SOILW:1-1 m below ground:12 hour fcst:
1019:593010472:d=2024082100:SOILW:1.6-1.6 m below ground:12 hour fcst:
1021:595484678:d=2024082100:SOILW:3-3 m below ground:12 hour fcst:

@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Oct 3, 2024
@jaymes-kenyon
Copy link
Contributor Author

@WenMeng-NOAA — Your test looks good! The WRFNAT dataset now contains 9 levels of TSOIL and SOILW, as expected. Thanks!

@WenMeng-NOAA
Copy link
Collaborator

@gspetro-NOAA @FernandoAndrade-NOAA You may start the UPP RTs on R&D platforms. There should be no baseline update with this PR.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Oct 3, 2024
@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs have completed on WCOSS2 without baseline change.

@gspetro-NOAA
Copy link
Collaborator

No changes in RT results across Hera, Hercules, and Orion. :)

@WenMeng-NOAA
Copy link
Collaborator

@gspetro-NOAA Please go head to approve this PR.

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit ae9c851 into NOAA-EMC:develop Oct 3, 2024
3 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Oct 3, 2024
Open
@jaymes-kenyon jaymes-kenyon deleted the soil_fields branch October 4, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

@gspetro-NOAA gspetro-NOAA Awaiting requested review from gspetro-NOAA

Assignees
No one assigned
Labels
MPAS No Baseline Change No baseline of the UPP regression tests are made. Ready for commit queue Ready for Review This PR is ready for code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RRFS-MPAS: TSOIL and SOILW needed in native-level GRIB2 files
4 participants
@jaymes-kenyon @WenMeng-NOAA @gspetro-NOAA @FernandoAndrade-NOAA