Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFS Total Cloud Fraction on Isobaric levels #539

Closed
WenMeng-NOAA opened this issue Aug 3, 2022 · 2 comments · Fixed by #540
Closed

GFS Total Cloud Fraction on Isobaric levels #539

WenMeng-NOAA opened this issue Aug 3, 2022 · 2 comments · Fixed by #540
Assignees
Labels
bug Something isn't working

Comments

@WenMeng-NOAA
Copy link
Collaborator

The total cloud fraction on isobaric levels are computed in UPP with cloud fraction on hybrid levels which are read from model outputs. @junwang-noaa reported GFS cloud fraction on isobaric levels have non-undefined values when cloud fraction on hybrid levels are not written out in mode outputs.

@WenMeng-NOAA
Copy link
Collaborator Author

@junwang-noaa and @HuiyaChuang-NOAA I think there is a bug in UPP code for rounding upper bound and lower bound of cloud fraction on isobaric levels at
https://github.com/NOAA-EMC/UPP/blob/develop/sorc/ncep_post.fd/MDL2P.f#L1319
The points with undefined values should be restricted. I conducted a test with model history files from Jun's test and saw all cloud fraction on isobaric levels are in undefined values since no 3D cloud faction outputs in Jun's test.
The test without the fix is gfs.t00z.master.grb2f003 at /scratch2/NCEPDEV/ovp/Wen.Meng/ncep_post/develop/jun.
The test with fix is gfs.t00z.master.grb2f003 at /scratch1/NCEPDEV/stmp2/Wen.Meng/gfs.2013040100

@HuiyaChuang-NOAA
Copy link
Collaborator

@WenMeng-NOAA thanks. good find. Are you moving max/min cap to after line 1321?

@WenMeng-NOAA WenMeng-NOAA self-assigned this Aug 3, 2022
@WenMeng-NOAA WenMeng-NOAA added the bug Something isn't working label Aug 3, 2022
@WenMeng-NOAA WenMeng-NOAA linked a pull request Aug 3, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants