Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates with the UPP refactor phase 2 merge from Bo Cui #235

Closed
BoCui-NOAA opened this issue Nov 30, 2020 · 1 comment · Fixed by #233
Closed

Updates with the UPP refactor phase 2 merge from Bo Cui #235

BoCui-NOAA opened this issue Nov 30, 2020 · 1 comment · Fixed by #233
Assignees
@BoCui-NOAA

Comments

@BoCui-NOAA
Copy link
Contributor

BoCui-NOAA commented Nov 30, 2020 •
edited by WenMeng-NOAA
Loading

Update the branch develop with the UPP refactor phase 2 merge from Bo Cui.
The changes are included:

  1. Add "implicit none" statements
  2. Modernize inequality statements, change the relational operators from Fortran 77 to 90, e.g. "GT" into ">"
    The Pull request UPP refactor phase 2 from Bo Cui #233 was submitted.
@BoCui-NOAA BoCui-NOAA changed the title Updates in EMC_post_refactor #233 Updates in EMC_post_refactor Nov 30, 2020
@BoCui-NOAA BoCui-NOAA changed the title Updates in EMC_post_refactor Updates in EMC_post_refactor , second release Nov 30, 2020
@WenMeng-NOAA WenMeng-NOAA changed the title Updates in EMC_post_refactor , second release Updates with the UPP refactor phase 2 merge from Bo Cui Dec 12, 2020
@BoCui-NOAA
Copy link
Contributor Author

Bo did the regression tests on Dell. The post executable generates bit-identical results as the EMC_post/develop commit
9fa1e08.

@WenMeng-NOAA WenMeng-NOAA linked a pull request Dec 15, 2020 that will close this issue
UPP refactor phase 2 from Bo Cui #233
Merged
@HelinWei-NOAA HelinWei-NOAA mentioned this issue Sep 20, 2021
Closed
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this issue Dec 14, 2022
@guoqing-noaa
set default FIX_GSI,FIX_UPP,FIX_CRTM for all platforms (NOAA-EMC#235)
83ebf81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoCui-NOAA BoCui-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UPP refactor phase 2 from Bo Cui BoCui-NOAA/EMC_post
2 participants
@WenMeng-NOAA @BoCui-NOAA