Skip to content

Commit

Permalink
Change gtg_algo inputs (MDLFLD.f) (#1076)
Browse files Browse the repository at this point in the history
* update gtg code revision

* Update INITPOST_NETCDF.f

add comments from rrfs_vi per difference

* Update INITPOST_NETCDF.f

reverse the comment change

* Add files via upload

Change inputs for gtg_algo from averaged (sfcshx, sfclhx) to instantaenous (twbs, qwbs)

* add hera rt log

* add hercules rt log

* add orion rt log

---------

Co-authored-by: hsin-mu lin <[email protected]>
Co-authored-by: gspetro-NOAA <[email protected]>
  • Loading branch information
3 people authored Oct 28, 2024
1 parent 54123f9 commit ce258fc
Show file tree
Hide file tree
Showing 4 changed files with 172 additions and 171 deletions.
7 changes: 4 additions & 3 deletions sorc/ncep_post.fd/MDLFLD.f
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
!! 24-01-24 | H Lin | switching GTG max (gtg) to gtgx3 from gtgx2 per gtg_algo() call
!! 24-02-20 | J Kenyon | Apply the PBLHGUST-related calculations to RRFS
!! 24-04-23 | E James| Adding smoke emissions (ebb) from RRFS
!! 24-10-07 | H Lin | Change inputs for gtg_algo from averaged (sfcshx, sfclhx) to instantaenous (twbs, qwbs)
!!
!! USAGE: CALL MDLFLD
!! INPUT ARGUMENT LIST:
Expand Down Expand Up @@ -107,7 +108,7 @@ SUBROUTINE MDLFLD
rlwtt, train, tcucn, o3, rhomid, dpres, el_pbl, pint, icing_gfip, icing_gfis, &
catedr,mwt,gtg,cit, REF_10CM, avgpmtf, avgozcon

use vrbls2d, only: slp, hbot, htop, cnvcfr, cprate, cnvcfr, sfcshx,sfclhx,ustar,z0,&
use vrbls2d, only: slp, hbot, htop, cnvcfr, cprate, cnvcfr, twbs, qwbs,ustar,z0,&
sr, prec, vis, czen, pblh, pblhgust, u10, v10, avgprec, avgcprate, &
REF1KM_10CM,REF4KM_10CM,REFC_10CM,REFD_MAX
use masks, only: lmh, gdlat, gdlon,sm,sice,dx,dy
Expand Down Expand Up @@ -4255,8 +4256,8 @@ SUBROUTINE MDLFLD
q(ista:iend,:,:),qqw(ista:iend,:,:),qqr(ista:iend,:,:),&
qqs(ista:iend,:,:),qqg(ista:iend,:,:),qqi(ista:iend,:,:),&
q2(ista:iend,:,:),&
ZINT(ista:iend,:,LP1),pblh(ista:iend,:),sfcshx(ista:iend,:),&
sfclhx(ista:iend,:),ustar(ista:iend,:),&
ZINT(ista:iend,:,LP1),pblh(ista:iend,:),twbs(ista:iend,:),&
qwbs(ista:iend,:),ustar(ista:iend,:),&
z0(ista:iend,:),gdlat(ista:iend,:),gdlon(ista:iend,:),&
dx(ista:iend,:),dy(ista:iend,:),u10(ista:iend,:),v10(ista:iend,:),&
GUST(ista:iend,:),avgprec(ista:iend,:),sm(ista:iend,:),sice(ista:iend,:),&
Expand Down
112 changes: 56 additions & 56 deletions tests/logs/rt.log.HERA
Original file line number Diff line number Diff line change
@@ -1,69 +1,69 @@
===== Start of UPP Regression Testing Log =====
UPP Hash Tested:
ee5b7128ceec81af617f64312c953adb64c1a26e
de558e8f18fe09c0ec47b2797358d4cb28154d8a

Submodule hashes:
-179cae1dd84401cf25d250bd9102e66560a9d328 sorc/libIFI.fd
-529f870d33b65c3b6c1aa3c3236b94efc3bd336d sorc/ncep_post.fd/post_gtg.fd

Run directory: /scratch2/NAGAPE/epic/Gillian.Petro/RTs/upp-rts/1075/ci/rundir/upp-HERA
Run directory: /scratch2/NAGAPE/epic/Gillian.Petro/RTs/upp-rts/1076/ci/rundir/upp-HERA
Baseline directory: /scratch2/NAGAPE/epic/UPP/test_suite

Total runtime: 00h:18m:35s
Test Date: 20241024 14:14:27
Total runtime: 00h:10m:40s
Test Date: 20241028 13:20:53
Summary Results:

10/24 14:06:48Z -fv3hafs test: your new post executable generates bit-identical HURPRS09.tm00 as the trunk
10/24 14:06:49Z -fv3gefs pe test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the trunk
10/24 14:07:09Z -fv3hafs pe test: your new post executable generates bit-identical HURPRS09.tm00 as the trunk
10/24 14:07:16Z -rap test: your new post executable generates bit-identical WRFPRS.GrbF16 as the trunk
10/24 14:07:18Z -rap test: your new post executable generates bit-identical WRFNAT.GrbF16 as the trunk
10/24 14:07:32Z -nmmb test: your new post executable generates bit-identical BGDAWP03.tm00.Grib2 as the trunk
10/24 14:07:34Z -nmmb test: your new post executable generates bit-identical BGRD3D03.tm00.Grib2 as the trunk
10/24 14:07:34Z -fv3r test: your new post executable generates bit-identical PRSLEV10.tm00 as the trunk
10/24 14:07:34Z -nmmb test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the trunk
10/24 14:07:39Z -fv3r test: your new post executable generates bit-identical NATLEV10.tm00 as the trunk
10/24 14:07:42Z -rtma pe test: your new post executable generates bit-identical NATLEV00.tm00 as the trunk
10/24 14:07:43Z -fv3r pe test: your new post executable generates bit-identical PRSLEV10.tm00 as the trunk
10/24 14:07:47Z -fv3r pe test: your new post executable generates bit-identical NATLEV10.tm00 as the trunk
10/24 14:07:49Z -rtma test: your new post executable generates bit-identical NATLEV00.tm00 as the trunk
10/24 14:07:49Z -rtma pe test: your new post executable generates bit-identical PRSLEV00.tm00 as the trunk
10/24 14:07:50Z -rtma pe test: your new post executable generates bit-identical IFIFIP00.tm00 as the trunk
10/24 14:07:54Z -rtma test: your new post executable generates bit-identical PRSLEV00.tm00 as the trunk
10/24 14:07:54Z -rtma test: your new post executable generates bit-identical IFIFIP00.tm00 as the trunk
10/24 14:07:59Z -rap pe test: your new post executable did generate changed results in WRFPRS.GrbF16
10/24 14:08:00Z -rap pe test: your new post executable generates bit-identical WRFNAT.GrbF16 as the trunk
10/24 14:08:03Z -fv3gefs test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the trunk
10/24 14:08:08Z -hrrr pe test: your new post executable generates bit-identical WRFTWO.GrbF04 as the trunk
10/24 14:08:10Z -hrrr pe test: your new post executable generates bit-identical WRFPRS.GrbF04 as the trunk
10/24 14:08:12Z -hrrr pe test: your new post executable generates bit-identical WRFNAT.GrbF04 as the trunk
10/24 14:08:19Z -nmmb pe test: your new post executable generates bit-identical BGDAWP03.tm00.Grib2 as the trunk
10/24 14:08:21Z -nmmb pe test: your new post executable generates bit-identical BGRD3D03.tm00.Grib2 as the trunk
10/24 14:08:21Z -nmmb pe test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the trunk
10/24 14:08:32Z -hrrr test: your new post executable generates bit-identical WRFTWO.GrbF04 as the trunk
10/24 14:08:34Z -hrrr test: your new post executable generates bit-identical WRFPRS.GrbF04 as the trunk
10/24 14:08:35Z -hrrr test: your new post executable generates bit-identical WRFNAT.GrbF04 as the trunk
10/24 14:13:28Z -fv3gfs test: your new post executable generates bit-identical gfs.t00z.master.grb2f006 as the trunk
10/24 14:13:33Z -fv3gfs test: your new post executable generates bit-identical gfs.t00z.sfluxgrbf006.grib2 as the trunk
10/24 14:13:34Z -fv3gfs test: your new post executable generates bit-identical gfs.t00z.special.grb2f006 as the trunk
10/24 14:14:07Z -fv3gfs pe test: your new post executable generates bit-identical gfs.t00z.master.grb2f006 as the trunk
10/24 14:14:12Z -fv3gfs pe test: your new post executable generates bit-identical gfs.t00z.sfluxgrbf006.grib2 as the trunk
10/24 14:14:12Z -fv3gfs pe test: your new post executable generates bit-identical gfs.t00z.special.grb2f006 as the trunk
10/24 14:07:49Z -Runtime: nmmb_test 00:01:34 -- baseline 00:01:00
10/24 14:08:35Z -Runtime: nmmb_pe_test 00:01:16 -- baseline 00:01:00
10/24 14:08:35Z -Runtime: fv3gefs_test 00:01:13 -- baseline 00:40:00
10/24 14:08:35Z -Runtime: fv3gefs_pe_test 00:00:34 -- baseline 00:40:00
10/24 14:08:35Z -Runtime: rap_test 00:01:03 -- baseline 00:02:00
10/24 14:08:36Z -Runtime: rap_pe_test 00:01:10 -- baseline 00:02:00
10/24 14:08:36Z -Runtime: hrrr_test 00:02:20 -- baseline 00:02:00
10/24 14:08:36Z -Runtime: hrrr_pe_test 00:01:57 -- baseline 00:02:00
10/24 14:13:39Z -Runtime: fv3gfs_test 00:07:34 -- baseline 00:15:00
10/24 14:14:25Z -Runtime: fv3gfs_pe_test 00:07:57 -- baseline 00:15:00
10/24 14:14:25Z -Runtime: fv3r_test 00:01:39 -- baseline 00:03:00
10/24 14:14:26Z -Runtime: fv3r_pe_test 00:01:32 -- baseline 00:03:00
10/24 14:14:26Z -Runtime: fv3hafs_test 00:00:33 -- baseline 00:03:00
10/24 14:14:26Z -Runtime: fv3hafs_pe_test 00:00:38 -- baseline 00:03:00
10/24 14:14:26Z -Runtime: rtma_test 00:01:39 -- baseline 00:03:00
10/24 14:14:27Z -Runtime: rtma_test_pe_test 00:01:50 -- baseline
10/28 13:13:15Z -fv3gefs test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the trunk
10/28 13:13:16Z -fv3gefs pe test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the trunk
10/28 13:13:23Z -fv3hafs test: your new post executable generates bit-identical HURPRS09.tm00 as the trunk
10/28 13:13:24Z -fv3hafs pe test: your new post executable generates bit-identical HURPRS09.tm00 as the trunk
10/28 13:13:49Z -rap test: your new post executable generates bit-identical WRFPRS.GrbF16 as the trunk
10/28 13:13:50Z -rap test: your new post executable generates bit-identical WRFNAT.GrbF16 as the trunk
10/28 13:14:02Z -nmmb pe test: your new post executable generates bit-identical BGDAWP03.tm00.Grib2 as the trunk
10/28 13:14:04Z -nmmb pe test: your new post executable generates bit-identical BGRD3D03.tm00.Grib2 as the trunk
10/28 13:14:04Z -nmmb pe test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the trunk
10/28 13:14:05Z -rap pe test: your new post executable did generate changed results in WRFPRS.GrbF16
10/28 13:14:06Z -rap pe test: your new post executable generates bit-identical WRFNAT.GrbF16 as the trunk
10/28 13:14:06Z -nmmb test: your new post executable generates bit-identical BGDAWP03.tm00.Grib2 as the trunk
10/28 13:14:08Z -nmmb test: your new post executable generates bit-identical BGRD3D03.tm00.Grib2 as the trunk
10/28 13:14:08Z -nmmb test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the trunk
10/28 13:14:19Z -fv3r test: your new post executable generates bit-identical PRSLEV10.tm00 as the trunk
10/28 13:14:23Z -fv3r test: your new post executable generates bit-identical NATLEV10.tm00 as the trunk
10/28 13:14:24Z -fv3r pe test: your new post executable generates bit-identical PRSLEV10.tm00 as the trunk
10/28 13:14:24Z -rtma pe test: your new post executable generates bit-identical NATLEV00.tm00 as the trunk
10/28 13:14:27Z -rtma pe test: your new post executable generates bit-identical PRSLEV00.tm00 as the trunk
10/28 13:14:28Z -rtma pe test: your new post executable generates bit-identical IFIFIP00.tm00 as the trunk
10/28 13:14:28Z -fv3r pe test: your new post executable generates bit-identical NATLEV10.tm00 as the trunk
10/28 13:14:30Z -rtma test: your new post executable generates bit-identical NATLEV00.tm00 as the trunk
10/28 13:14:34Z -rtma test: your new post executable generates bit-identical PRSLEV00.tm00 as the trunk
10/28 13:14:34Z -rtma test: your new post executable generates bit-identical IFIFIP00.tm00 as the trunk
10/28 13:14:44Z -hrrr pe test: your new post executable generates bit-identical WRFTWO.GrbF04 as the trunk
10/28 13:14:46Z -hrrr pe test: your new post executable generates bit-identical WRFPRS.GrbF04 as the trunk
10/28 13:14:47Z -hrrr pe test: your new post executable generates bit-identical WRFNAT.GrbF04 as the trunk
10/28 13:15:07Z -hrrr test: your new post executable generates bit-identical WRFTWO.GrbF04 as the trunk
10/28 13:15:08Z -hrrr test: your new post executable generates bit-identical WRFPRS.GrbF04 as the trunk
10/28 13:15:09Z -hrrr test: your new post executable generates bit-identical WRFNAT.GrbF04 as the trunk
10/28 13:20:03Z -fv3gfs test: your new post executable generates bit-identical gfs.t00z.master.grb2f006 as the trunk
10/28 13:20:06Z -fv3gfs test: your new post executable generates bit-identical gfs.t00z.sfluxgrbf006.grib2 as the trunk
10/28 13:20:06Z -fv3gfs test: your new post executable generates bit-identical gfs.t00z.special.grb2f006 as the trunk
10/28 13:20:45Z -fv3gfs pe test: your new post executable generates bit-identical gfs.t00z.master.grb2f006 as the trunk
10/28 13:20:49Z -fv3gfs pe test: your new post executable generates bit-identical gfs.t00z.sfluxgrbf006.grib2 as the trunk
10/28 13:20:49Z -fv3gfs pe test: your new post executable generates bit-identical gfs.t00z.special.grb2f006 as the trunk
10/28 13:14:15Z -Runtime: nmmb_test 00:01:23 -- baseline 00:01:00
10/28 13:14:15Z -Runtime: nmmb_pe_test 00:01:19 -- baseline 00:01:00
10/28 13:14:15Z -Runtime: fv3gefs_test 00:00:30 -- baseline 00:40:00
10/28 13:14:16Z -Runtime: fv3gefs_pe_test 00:00:31 -- baseline 00:40:00
10/28 13:14:16Z -Runtime: rap_test 00:01:05 -- baseline 00:02:00
10/28 13:14:16Z -Runtime: rap_pe_test 00:01:21 -- baseline 00:02:00
10/28 13:15:17Z -Runtime: hrrr_test 00:02:24 -- baseline 00:02:00
10/28 13:15:17Z -Runtime: hrrr_pe_test 00:02:02 -- baseline 00:02:00
10/28 13:20:20Z -Runtime: fv3gfs_test 00:07:21 -- baseline 00:15:00
10/28 13:20:51Z -Runtime: fv3gfs_pe_test 00:08:04 -- baseline 00:15:00
10/28 13:20:51Z -Runtime: fv3r_test 00:01:38 -- baseline 00:03:00
10/28 13:20:51Z -Runtime: fv3r_pe_test 00:01:43 -- baseline 00:03:00
10/28 13:20:52Z -Runtime: fv3hafs_test 00:00:38 -- baseline 00:03:00
10/28 13:20:52Z -Runtime: fv3hafs_pe_test 00:00:39 -- baseline 00:03:00
10/28 13:20:52Z -Runtime: rtma_test 00:01:49 -- baseline 00:03:00
10/28 13:20:53Z -Runtime: rtma_test_pe_test 00:01:43 -- baseline
No changes in test results detected.
===== End of UPP Regression Testing Log =====
Loading

0 comments on commit ce258fc

Please sign in to comment.