Merge release hotfix into develop #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RUN_CONTINUE = .false. ENS_SPS = .false. TOTAL_MEMBER = 1
fixes problem with MPI_Comm_Split in openmpi when hash is negative
* Add nems documentation in doc directory *Include in .gitignore NEMS/doc/html/ and NEMS/doc/webpage.tar.gz *Remove milestones.dox which is no longer needed *Modify Makefile to include doxygen command on Hera *Remove in prep_inputs.py two functions related to milestones * Remove webpage.tar.gz file * Update NEMS documentation *Add Doxyfile in NEMS/.gitignore * Update based on documentation meeting
* Modify license file * Fix typo in license
|
The changes look good, would you please make a PR to ufs-weather-model too, so we can test it on hera/wcoss. |
MinsukJi-NOAA
requested review from
DeniseWorthen
and removed request for
RatkoVasic-NOAA
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #34 - merge hot fixes in public release branch to develop branch.
Full regression tests were passed on Hera:
ufs-weather-model (rt.sh): https://github.com/MinsukJi-NOAA/ufs-weather-model/blob/test_nems_hotfix_merge_into_develop/tests/RegressionTests_hera.intel.log
ufs-weather-model (NEMSCompsetRun): https://github.com/MinsukJi-NOAA/ufs-weather-model/blob/test_nems_hotfix_merge_into_develop/log/report-hera.intel-log/rtreport.txt
ufs-s2s-model (NEMSCompsetRun): https://github.com/MinsukJi-NOAA/ufs-s2s-model/blob/test_nems_hotfix_merge_into_develop/log/report-hera.intel-log/rtreport.txt