Version 2.5.1 #23
Merged
Version 2.5.1 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove transitive linking of w3nco and bacio and let user decide Nemsio library is not compiled using compiler flags to promote real numbers. There is no _4, _d and _8 version of nemsio. Nemsio library has overloaded functions that provide interfaces for reading and writing data in both real(4) and real(8) arrays, using functions from w3nco library (getgbm subroutine). There are 4 such routines in nemsio that read grib data, 2 for real(4)and two for real(8) arrays. w3nco library does not have an overloaded getgbm subroutine. So no matter which version of w3nco is linked (w3nco4 or w3nci_d), two of the nemsio routines will be wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't transitively link to bacio and w3nco