Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for rotated lat/lon in ip2 code to support wgrib2 #211

Closed
edwardhartnett opened this issue Dec 18, 2023 · 7 comments · Fixed by #231
Closed

add support for rotated lat/lon in ip2 code to support wgrib2 #211

edwardhartnett opened this issue Dec 18, 2023 · 7 comments · Fixed by #231
Assignees
Labels
enhancement New feature or request

Comments

@edwardhartnett
Copy link
Contributor

wgrib2 has it's own internal copy of the ip2 code, with come changes to support rotated lat/lon grids.

These need to be supported in NCEPLIBS-ip.

When @webisu gets back from vacation in January he can provide details.

Somehow the lack of rotated lat/lon is causing two different versions of wgrib2 to be built, one with, and one without. See NOAA-EMC/wgrib2#70.

This is needed for the wgrib2-3.3.0 release, but first we have to do the wgrib2-3.2.0 release. So this will be needed sometime in Q1 of 2024 (as a new release of NCEPLIBS-ip which can handle rotated lat/lon and can be used by wgrib2.)

@edwardhartnett
Copy link
Contributor Author

@AlexanderRichert-NOAA we need this to be fixed to get the new wgrib2 build working.

@AlexanderRichert-NOAA
Copy link
Contributor

Okay, looking into this now

@AlexanderRichert-NOAA
Copy link
Contributor

@webisu @edwardhartnett would you be able to point me to the missing routines? I seem to recall Kyle's merge of ip2 into ip was fairly comprehensive, but I may be missing something.

@webisu
Copy link

webisu commented Mar 1, 2024 via email

@AlexanderRichert-NOAA
Copy link
Contributor

Is there a file (or couple files if there are two grid numbers to test) and a wgrib2 command+expected result that I can test with? I'm assuming this will involve the -new_grid rot-ll... option?

I'll have to refresh myself on grib standards/grid definitions/etc. but I'm hoping the consolidated ip code will help here.

@AlexanderRichert-NOAA
Copy link
Contributor

@webisu if I've understood the requirement correctly, the idea is to be able to provide the ip library directly with GDT value 32768 or 32769. If that is the case, please see #231 and see if that looks reasonable. In short, the current ip library supports those grids for grib2, but uses GDT number 1 for both (which I'm not sure I understand), then infers E vs. B based on some offsets in the GDT data. The PR would allow it take the 3276x values directly. If that seems like the right idea I can add unit testing and push the changes.

@webisu
Copy link

webisu commented Mar 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants