Update for g2cio.c and test #589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In g2c_file_io(), define chat *bvar as signed char. The generic char on majority of platforms is signed, except ARM Linux where it is unsigned. Updated test for 1-byte ints to add a fourth read/write and test special condition where the value read will not equal what is written that mimics Arm Linux.
Return last arg to char.
For GCC, adding "-Wno-error=pointer-sign" to allow that behavior.
|
@edhartnett After closing #583, I have this new PR. IMO, the added logic to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In g2c_file_io(), define chat *bvar as signed char. The generic char on majority of platforms is signed, except ARM Linux where it is unsigned.
Updated test for 1-byte ints to add a fourth read/write and test special condition where the value read will not equal what is written that mimics Arm Linux.