Allow MOM6 to use a mesh optionally #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* read config variable 'use_mommesh' in ufs; default is false to have mom cap run on grid
|
Changes to allow this as an option looks good to me. But I'll let @jiandewang be the one who approves so he can control the timing of when this goes in if we're waiting on other things first, etc. Thanks @DeniseWorthen |
|
Ready for review; logs are posted at ufs-weather-model PR#399 |
|
Changes all seem fine to me, but I do not know what the order is for commits in terms of waiting for the structural changes that are coming from GFDL. @jiandewang is it okay to move forward w/this or are you waiting for the other? |
|
Denise’s change only involves couple of lines in cap so will not impact
GFDL’s big PR. Go ahead for this PR. I will approval and merge the mom code
this afternoon.
On Thu, Feb 11, 2021 at 11:56 AM Jessica Meixner ***@***.***> wrote:
Changes all seem fine to me, but I do not know what the order is for
commits in terms of waiting for the structural changes that are coming from
GFDL. @jiandewang <https://github.com/jiandewang> is it okay to move
forward w/this or are you waiting for the other?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#54 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADMGASZTJXDQPN6DYPS6IF3S6QD2TANCNFSM4WY2D26Q>
.
--
Jiande Wang
IMSG at NOAA/NWS/NCEP/EMC
cubic 2088
[email protected]
phone:3016833725
|
JessicaMeixner-NOAA
approved these changes
Feb 11, 2021
jiandewang
pushed a commit
to jiandewang/MOM6
that referenced
this pull request
Jun 17, 2021
merge in dev/gfdl updates
jiandewang
pushed a commit
to jiandewang/MOM6
that referenced
this pull request
May 17, 2022
jiandewang
pushed a commit
to jiandewang/MOM6
that referenced
this pull request
May 17, 2022
- Scaling of OBC's dz_src. - Scaling of CS%IDatu in MOM_barotropic.
jiandewang
pushed a commit
to jiandewang/MOM6
that referenced
this pull request
May 17, 2022
jiandewang
pushed a commit
to jiandewang/MOM6
that referenced
this pull request
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements configurable settings which allow specifying that the MOM6 cap should use a mesh rather than a grid. The default is to use the grid, which is the current use in ufs-weather-model (both cpld and datm). Once MOM6 Issue #47 is resolved, we can switch the ufs-weather-model to use the Mesh by default.
See UFS issue #398 for details and related PR #399