-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications for gfsda.v16.3.0 branch #412
Modifications for gfsda.v16.3.0 branch #412
Conversation
…nd AVHRR (3) Point CRTM cloud coefficient file to GFDL one.
Tagging @ADCollard @HaixiaLiu-NOAA @XuLi-NOAA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good to me.
@MichaelLueken-NOAA We have some changes in GSI fix files. There are two historical satinfo files and two historical convinfo files. Could you help us add this new directory into the gfsv16_historical? |
Both For example, the fix associated with WCOSS2 tag |
@ADCollard and @HaixiaLiu-NOAA There are two historical satinfo files and two historical convinfo files. The global-workflow will these the convinfo and satinfo according to the cycle date/time from this directory. Please see the corresponding PR in global-workflow related to this PR |
@RussTreadon-NOAA Thanks for pointing out the issue in the fix file. I will use the gfsda.v16.2.0 as an example to create a proper GSI fix for v16.3 implementation. |
@emilyhcliu Fix submodule branch In release/gfsda.v16.3.0_emily:
Once the changes in this PR are merged to |
@MichaelLueken-NOAA Thanks for your detailed instruction on how to create the global only fix directory under gfsda.v16.3.0 |
@HaixiaLiu-NOAA @ADCollard @MichaelLueken-NOAA @RussTreadon-NOAA I will merge this branch back to release/gfsda.v16.3.0 Please give me an OK or let me know if you have any questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@emilyhcliu I just checked the changed files in this PR and I don't see the update to fix. I do see that the |
@MichaelLueken-NOAA I did the following after I pruned the files in the fix directory:
|
Emily,
rmesh(4)=50.0 is the final decision?
There seems to be no final decision yet.
Xu
…On Thu, Jun 16, 2022 at 2:44 PM emilyhcliu ***@***.***> wrote:
@emilyhcliu <https://github.com/emilyhcliu> requested your review on: #412
<#412> Modifications for
gfsda.v16.3.0 branch.
—
Reply to this email directly, view it on GitHub
<#412 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANEMLJT2AXO24QSIQTYDUWLVPNYWVANCNFSM5Y7W2PPQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Change the following to gfsda.v16.3.0 branch:
A. /scripts/exglobal_atmos_analysis.sh:
(1) set cao_check to true
(2) set ta2tb to true
(3) set rmesh(4)=50 for AVHRR and VIIRS (NSST application)
(4) point CRTM cloud coefficient file to GFDL one
B. /modulefiles/gsi_common.lua:
(1) change crtm_ver from 2.3.0 to 2.4.0
C. Create specific fix branch which include fix files for global application only (DA_GFSv16.3.0_global_only)