Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build_all.sh argument list #1428

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

RussTreadon-NOAA
Copy link
Contributor

Description

This PR updates the argument list for build_all.sh to be consistent with g-w PR #3186 which was merged into g-w develop on 12/24/2024.

Two files are modified

ci/run_ci.sh
prototypes/gen_prototype.sh

Companion PRs

None

Issues

Resolves #1427

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmaerosnowDA
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_hybatmDA

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Dec 26, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

Attention @DavidNew-NOAA : I have an open question regarding whether or not we need to retain directory prototypes and its contents. It does not appear that we actively use this directory.

I updated build_all.sh in prototypes/gen_prototype.sh so we could

  1. go ahead and merge this PR into develop and address the prototypes question later, or
  2. remove prototypes as part of this PR pending agreement from DA staff

@DavidNew-NOAA
Copy link
Collaborator

@RussTreadon-NOAA If this directory is not in use, I'm more than happy for it to be gotten rid of. However, I think we should get feedback from DA staff first, and too many of them are on leave. I wouldn't let it hold up this PR.

@RussTreadon-NOAA
Copy link
Contributor Author

Agreed. We can merge these changes and circle back regarding what to do with prototypes.

Copy link
Collaborator

@DavidNew-NOAA DavidNew-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward changes

@RussTreadon-NOAA RussTreadon-NOAA merged commit eec2e1b into develop Dec 26, 2024
5 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/update_gw_build branch December 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update g-w build_all.sh
2 participants