Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run g-w linker script before ctest for prepoceanobs task #1034

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Run g-w linker script before ctest for prepoceanobs task #1034

merged 6 commits into from
Apr 12, 2024

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented Apr 10, 2024 •
edited
Loading

In anticipation of the merging of NOAA-EMC/global-workflow#2459 , the test_gdasapp_soca_setup_obsprep ctest which sets up for test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS now runs the global-workflow sorc/link_workflow.sh script to allow the observation config files to be accessed in a global-workflow-compliant way.

Effectively addresses #1032

guillaumevernieres
guillaumevernieres previously approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

test/soca/gw/setup_obsprep.sh Outdated Show resolved Hide resolved
apchoiCMD
apchoiCMD previously approved these changes Apr 10, 2024
View reviewed changes
@AndrewEichmann-NOAA AndrewEichmann-NOAA marked this pull request as ready for review April 10, 2024 16:00
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 12, 2024
@emcbot emcbot added orion-GW-RT-Running Automated testing with global-workflow running on Orion hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed orion-GW-RT Queue for automated testing with global-workflow on Orion hera-GW-RT Queue for automated testing with global-workflow on Hera labels Apr 12, 2024
@emcbot
Copy link

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Fri Apr 12 08:36:37 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Apr 12 09:37:57 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Apr 12 10:04:08 CDT 2024
Tests: 94% tests passed, 3 tests failed out of 53
	1743 - test_gdasapp_fv3jedi_fv3inc (Failed)
	1777 - test_gdasapp_atm_jjob_var_run (Failed)
	1778 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1034/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Apr 12, 2024
@emcbot
Copy link

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Apr 12 13:58:19 UTC 2024 on hfe11
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Apr 12 14:50:17 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Apr 12 15:10:43 UTC 2024
Tests: 92% tests passed, 4 tests failed out of 53
	1742 - test_gdasapp_fv3jedi_fv3inc (Failed)
	1763 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1776 - test_gdasapp_atm_jjob_var_run (Failed)
	1777 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1034/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Apr 12, 2024
@guillaumevernieres guillaumevernieres merged commit fadffb0 into develop Apr 12, 2024
17 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/run_linker branch April 12, 2024 15:38
danholdaway added a commit that referenced this pull request Apr 15, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
08873f1 
* upstream/develop:
  remove seviri from gdas_prototype_3d yaml (#1043)
  Fix GW jjob tests for upcoming GW PR #2420 (#1041)
  Fix test output for fv3jedi_fv3inc.h (#1039)
  Run g-w linker script before ctest for prepoceanobs task (#1034)
  Update femps and fv3-jedi-lm (#1036)
  Add ability for JEDI-to-FV3 increment converter to process ensembles (#1022)
  Add AVHRR/NOAA-15/18/19 assimilation to end-to-end GDASApp validation (#997)
  Catch error when trying to copy missing obs files from DATA to ROTDIR in prepoceanobs (#1028)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apchoiCMD apchoiCMD apchoiCMD approved these changes

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@CoryMartin-NOAA CoryMartin-NOAA Awaiting requested review from CoryMartin-NOAA

Assignees
No one assigned
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndrewEichmann-NOAA @emcbot @CoryMartin-NOAA @guillaumevernieres @apchoiCMD