Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regexp to select the marine obs is too restrictive #869

Closed
guillaumevernieres opened this issue Jan 24, 2024 · 0 comments · Fixed by #876
Closed

Regexp to select the marine obs is too restrictive #869

guillaumevernieres opened this issue Jan 24, 2024 · 0 comments · Fixed by #876
Assignees
Labels
bug Something isn't working soca

Comments

@guillaumevernieres
Copy link
Contributor

I assumed that would be the case, and it is. Doing things like this ??????????????-STAR-L3U_GHRSST-SSTsubskin-AVHRRF_MB-ACSPO_V2.80-v02.0-fv01.0.nc for example, is not general enough to work. We need to replace ? with * and remove the version number to capture more of the possible cases.

@guillaumevernieres guillaumevernieres added bug Something isn't working soca labels Jan 24, 2024
@guillaumevernieres guillaumevernieres self-assigned this Jan 24, 2024
guillaumevernieres added a commit that referenced this issue Jan 26, 2024
Things done:
- Assumes that the obs will be organized like something like this from
now on:
```console
└── gdas.20180415
    └── 12
        └── ocean
            ├── adt
            │   ├── rads_adt_3a_2018105.nc
            │   └── rads_adt_3b_2018105.nc
            ├── icec
            │   ├── AMSR2-SEAICE-NH_v2r2_GW1_s201804150835180_e201804151014170_c201804151052280.nc
            │   ├── AMSR2-SEAICE-NH_v2r2_GW1_s201804151014190_e201804151150170_c201804151309570.nc
            │   ├── AMSR2-SEAICE-SH_v2r2_GW1_s201804150835180_e201804151014170_c201804151052280.nc
            │   └── AMSR2-SEAICE-SH_v2r2_GW1_s201804151014190_e201804151150170_c201804151309570.nc
            ├── sss
            └── sst
                ├── 20180415095000-STAR-L3U_GHRSST-SSTsubskin-AVHRRF_MB-ACSPO_V2.80-v02.0-fv01.0.nc
                ├── 20180415114000-STAR-L3U_GHRSST-SSTsubskin-AVHRRF_MB-ACSPO_V2.80-v02.0-fv01.0.nc
                └── 20180415132000-STAR-L3U_GHRSST-SSTsubskin-AVHRRF_MB-ACSPO_V2.80-v02.0-fv01.0.nc
```
- Use of the `*` wildcard instead of `?` to simplify the obs file
selection
- Addition of binning for the sst retrieval
- The `soca` # needs to be more recent.
- This wasn't planned as part of this work, but the bump localization
was having issues, so I replaced it with `diffusion`

### Issues addressed
- fixes #869 
- fixes #874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working soca
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant