Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect mapping type for ifrac #17

Closed
DeniseWorthen opened this issue Oct 5, 2020 · 0 comments
Closed

incorrect mapping type for ifrac #17

DeniseWorthen opened this issue Oct 5, 2020 · 0 comments
Assignees

Comments

@DeniseWorthen
Copy link
Collaborator

The field Si_ifrac being exported by CMEPS to the ATM is currently being mapped with maptype mapnstod_consf (non-frac) and mapconsf (frac_mode). This is inconsistent with the value expected by FV3 (which assumes that the ifrac imported is weighted by the whole atm grid cell). The fix is to map by mapnstod_consd for nems_orig and mapconsd for nems_frac in med_fraction_mod.F90. This fix will change all current baselines.

This fix will be implemented as through CMEPS PR #10. This PR implements other changes which are required for CESM budget calculations but do not affect the NEMS implementation.

@DeniseWorthen DeniseWorthen self-assigned this Oct 8, 2020
DeniseWorthen added a commit to ufs-community/ufs-weather-model that referenced this issue Nov 9, 2020
…led model (#254)

* Implements a bugfix for the mapping of ifrac for both nems_orig and nems_frac in CMEPS: issue (#17)[NOAA-EMC/CMEPS#17]
* Adds field-packing for performance improvements in CMEPS: issue (#23)[NOAA-EMC/CMEPS#23]
* Uses module file fv3_debug when DEBUG=Y is specified and fv3_debug is available
* Shortens the nems.configure file name used with the coupled model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant