-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to PineAPPL v1
#206
base: main
Are you sure you want to change the base?
Conversation
When this is working I suggest you also try to implement #183 - this should decrease the time and space needed to perform an evolution. Also the required changes should be minimal. |
Thanks for letting me know about this! I will surely do once this is working indeed. |
db39b0b
to
9e2620a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Some really minor comments:
- Just a small question: why
key_values
are still around and now we don't have just metadata ? Why the theory card is still saved tokey_values
?
pineko/src/pineko/scale_variations.py
Lines 238 to 240 in e8d7282
# propagate metadata | |
for k, v in ori_grid.key_values.items(): | |
new_grid.set_key_value(k, v) |
- I did not check, I'm able to produce a real FKtable myself.
Indeed, it should be |
Thanks a lot @giacomomagni for the review! I will address them once I am in front of a computer this afternoon.
Some of these |
Co-authored-by: Giacomo Magni <[email protected]>
1052e70
to
cfe229c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it works it's good for me!
Co-authored-by: Giacomo Magni <[email protected]>
Perfect, thanks! Let's wait for #215 and we can test it here. |
This PR tests the new Python interface of the upcoming PineAPPL
v1
. There are a few notable changes affectingpineko
directly:convolutions
attributes. These information are no longer determined from the metadata (address the shortcomings discussed in Bump pineappl version nnpdf#2129 (comment) and Allow evolution and convolution with different ekos for a single grid #181 (comment)).operator1
andoperator2
in favor of justoperators
.pdf1
andpdf2
in favor ofpdfs
.xia
.The only remaining thing for which we will still require an ad-hoc hack/tweak is the checks that the PDFs are ordered according to the type of convolutions. This is an LHAPDF problem so there isn't much that we can do.
This will deprecate #192.
Remaining to do: