Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cschwan, as you know from #89 we are dealing with normalizations, and I proposed to skip
pineappl remap
and write instead something in python.The idea is:
Nevertheless, point 2 is not that easy, so I tried to figure a way out of it, as easy as possible.
I had a look inside
pineappl remap
, and I found that you useBinRemapper
to apply normalization:https://github.com/N3PDF/pineappl/blob/32e63c92cd9ea8358d6e193e068a9ee33d917979/pineappl_cli/src/remap.rs#L155-L161
and this is the only place where the CLI argument
norm
appears.So my idea for point 2 would be:
grid.more_members.upgrade()
should guarantee is available)BinRemapper
Unfortunately, I noticed the
remapper
inside themore_members
is an option, so it might not be available, then: what should I do in the case?Moreover, I would need to implement a getter for
bin_remapper
in python, and before even inpineappl
crate. Then I was wondering:normalize
/renormalize
a method ofGrid
directly insidepineappl
?P.S.: I needed a commit to open the PR, but I had nothing to commit, so the moment we start I'll just squash it and remove the empty
help
file