Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat 1-point datasets equally in sequential and parallel fits #2276

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

scarlehoff
Copy link
Member

@scarlehoff scarlehoff commented Feb 12, 2025

Due to the shape-changing nature of boolean masks we decided to just put single-point datasets in training when running in GPU. This PR removes that limitation by just accepting the point in both training and validation and setting to 0 the row and column in the inverse covmat (so the masking happens at the level of the loss)*

If this works ok, #2138 comes for free.

@RoyStegeman @achiefa I want to run a few tests first before considering this good:

  • That Etr and Evl are ok for multireplica fits (they are ok for single replicas given that the regression test pass)
  • Running a fit with only single-point datasets (this is actually broken in master)
  • Experiments with one single dataset which is one-single-point.
  • Check whether the written down replicas are really the same in sequential and parallel
    • Add a test for exactly this situation
    • Separate the .csv files per replica
    • In principle the table of written down replicas is not affected by the trick used by n3fit_data but needs to be checked

At the moment the .csv files are only stored for the last replica, once per replica and with all data in each of them. However, the information itself is correct.

(any help running the checks would be appreciated ofc, the more eyes the better)

This is needed for tree-saving reasons.

@scarlehoff scarlehoff added the n3fit Issues and PRs related to n3fit label Feb 12, 2025
@scarlehoff scarlehoff marked this pull request as draft February 12, 2025 12:05
@scarlehoff scarlehoff added the run-fit-bot Starts fit bot from a PR. label Feb 12, 2025
Copy link

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n3fit Issues and PRs related to n3fit run-fit-bot Starts fit bot from a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants