Treat 1-point datasets equally in sequential and parallel fits #2276
+179
−134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the shape-changing nature of boolean masks we decided to just put single-point datasets in training when running in GPU. This PR removes that limitation by just accepting the point in both training and validation and setting to 0 the row and column in the inverse covmat (so the masking happens at the level of the loss)*
If this works ok, #2138 comes for free.
@RoyStegeman @achiefa I want to run a few tests first before considering this good:
.csv
files per replican3fit_data
but needs to be checkedAt the moment the
.csv
files are only stored for the last replica, once per replica and with all data in each of them. However, the information itself is correct.(any help running the checks would be appreciated ofc, the more eyes the better)
This is needed for tree-saving reasons.