Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCD TTB ATLAS #1837

Closed
wants to merge 11 commits into from
Closed

NCD TTB ATLAS #1837

wants to merge 11 commits into from

Conversation

t7phy
Copy link
Member

@t7phy t7phy commented Nov 7, 2023

No description provided.

@t7phy t7phy marked this pull request as ready for review December 7, 2023 15:54
@t7phy t7phy requested a review from scarlehoff December 7, 2023 15:54
Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Here the report of differences for this one. As with the total, it is important to know whether the differences are bug or features. In particular for ATLAS_TTBAR_8TEV_LJ_DIF the data itself is different (not by much)
while for ATLAS_TTBAR_8TEV_2L_DIF the problem of some observables might be just the treatment of some uncertainties.

 > Testing old: ATLAS_TOPDIFF_DILEPT_8TEV_TTM vs new: ATLAS_TTBAR_8TEV_2L_DIF_MTTBAR
# Differences in the computation of chi2 545.25 vs 757.23
    The covmats are different even the diagonal

 > Testing old: ATLAS_TOPDIFF_DILEPT_8TEV_TTMNORM vs new: ATLAS_TTBAR_8TEV_2L_DIF_MTTBAR-NORM
 > Everything ok!
 > Testing old: ATLAS_TOPDIFF_DILEPT_8TEV_TTRAP vs new: ATLAS_TTBAR_8TEV_2L_DIF_YTTBAR
# Differences in the computation of chi2 341.03 vs 403.29
    The covmats are different even the diagonal
> Testing old: ATLAS_TOPDIFF_DILEPT_8TEV_TTRAPNORM vs new: ATLAS_TTBAR_8TEV_2L_DIF_YTTBAR-NORM
> Everything ok!

The data is different for ATLAS_TTBAR_8TEV_LJ_DIF it is important to know whether it is a feature or a bug. The errors range from a few per-mille and a percent for every dataset other than ATLAS_TTBAR_8TEV_LJ_DIF_MTTBAR for which it goes to a few percent:

1      1.138890  1.118623  1.018117
2      1.115040  1.106053  1.008125
3      0.678057  0.681068  0.995580
4      0.349925  0.352835  0.991754
5      0.146934  0.148915  0.986694
6      0.036742  0.037503  0.979696
7      0.004360  0.004613  0.945229

@t7phy
Copy link
Member Author

t7phy commented Dec 8, 2023

@scarlehoff all the distributions in ATLAS 13 TEV LJ are new, everything else is old

@scarlehoff
Copy link
Member

Report for those https://vp.nnpdf.science/xUkXJO0vQiWlx1s3MEQW0g==

@scarlehoff
Copy link
Member

For ATLAS_TTBAR_8TEV_LJ_DIF the only two that appear in NNPDF40 are

ATLAS_TTB_DIFF_8TEV_LJ_TRAPNORM
and ATLAS_TTB_DIFF_8TEV_LJ_TTRAPNORM

And the differences there are sub-% so I think it is ok. The covmats are quite different so we need a legacy variant.

@t7phy
Copy link
Member Author

t7phy commented Dec 18, 2023

For ATLAS_TTBAR_8TEV_LJ_DIF the only two that appear in NNPDF40 are

ATLAS_TTB_DIFF_8TEV_LJ_TRAPNORM and ATLAS_TTB_DIFF_8TEV_LJ_TTRAPNORM

And the differences there are sub-% so I think it is ok. The covmats are quite different so we need a legacy variant.

This seems to be the cases where the dataset differences and the covmat differences come from the treatment of assym uncer.

scarlehoff added a commit that referenced this pull request Feb 1, 2024
@scarlehoff scarlehoff force-pushed the new_commondata_collected branch from e64d092 to 929b692 Compare February 1, 2024 14:26
@scarlehoff scarlehoff closed this Feb 1, 2024
scarlehoff added a commit that referenced this pull request Feb 6, 2024
scarlehoff added a commit that referenced this pull request Feb 7, 2024
scarlehoff added a commit that referenced this pull request Feb 7, 2024
scarlehoff added a commit that referenced this pull request Feb 12, 2024
@scarlehoff scarlehoff deleted the ncd_top_2 branch February 15, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants