[WIP] Reader for new commondata #1548
Conversation
scarlehoff
force-pushed
the
reader_for_new_commondata
branch
from
f8409fd to
4c24156
Compare
…dtaed metadata.yaml
scarlehoff
force-pushed
the
reader_for_new_commondata
branch
from
0a94f2d to
8d63b67
Compare
|
I think it is entirely proper to deprecate python 3.8 whenever we get around merging this. |
| " raise ValidationError(f\"{path_str} is not a valid path\") from e\n", | ||
| " \n", | ||
| "@Parser\n", | ||
| "def ValidOperation(op_str: str) -> str:\n", |
There was a problem hiding this comment.
Would it make sense to use enums, or Literal for better structure here?
There was a problem hiding this comment.
For the OPs list you mean?
There was a problem hiding this comment.
Yes indeed. Would make for better error messages.
| "\n", | ||
| "# Scalar parsers\n", | ||
| "@Parser\n", | ||
| "def ValidPath(path_str: str) -> Path:\n", |
There was a problem hiding this comment.
Do we want things with more checks, like ExistingFilePath? For fun I tried to reach the error using the visible keys on my keyboard and could not.
There was a problem hiding this comment.
I'll see when I actually use it but I'm not sure at this stage the path will be testable for existence
There was a problem hiding this comment.
Should be fine either way. Don't have to check for everything at this stage but it sure is nice when sensible.
| " FK_tables: list\n", | ||
| " operation: ValidOperation\n", | ||
| " conversion_factor: float = 1.0\n", | ||
| " apfelcomb: dict = None\n", |
There was a problem hiding this comment.
This should be Optional[dict]. And probably more structured.
There was a problem hiding this comment.
Plan is to remove all dictionaries (if that's what you mean with the structure)
There was a problem hiding this comment.
Yes, but also that as it is the default does not type check.
…ary files for the reader (no removals or rawdata)
…ary files for the reader (no removals or rawdata)
We used #1526 as a scratchpad during the meeting so I'll leave it be and instead move here whatever is needed.
For now I've added just a jupyter notebook that reads the new commondata into pandas dataframes.
@enocera @Zaharid if you are ok with those df I'll port the rest (
coredata.pyandcore.py, specs and so) using that as the underlying objects.(why would the test pass here but not in #1500?)