Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

160 Docusaurus-search-local plugin working #162

Merged
merged 4 commits into from
Dec 3, 2024
Merged

160 Docusaurus-search-local plugin working #162

merged 4 commits into from
Dec 3, 2024

Conversation

theangchen
Copy link
Collaborator

@theangchen theangchen commented Nov 22, 2024 •
edited
Loading

Working locally:

Screenshare.-.2024-11-22.3_20_34.PM.mp4
  • The override is to get it working with Docusaurus v3
  • Context here

@theangchen theangchen linked an issue Nov 22, 2024 that may be closed by this pull request
Docs - Add Search feature #160
Closed
@theangchen theangchen marked this pull request as draft November 22, 2024 23:29
@theangchen theangchen changed the title 160 Docusaurus search local plugin working 160 Docusaurus-search-local plugin working Nov 22, 2024
@theangchen
Copy link
Collaborator Author

Looking into updating styles for focus color and magnifying glass icon.

@theangchen
Copy link
Collaborator Author

theangchen commented Dec 3, 2024 •
edited
Loading

Recommended method of overriding colors (in readme) is to use rgb and !important. Don't come for me! (Here)

@theangchen theangchen marked this pull request as ready for review December 3, 2024 22:56
jaygiang
jaygiang approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@jaygiang jaygiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@theangchen theangchen merged commit faa8fa9 into main Dec 3, 2024
1 check passed
@theangchen theangchen deleted the 160-docs---research-search-feature branch December 3, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaygiang jaygiang jaygiang approved these changes

@thgaskell thgaskell thgaskell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs - Add Search feature
3 participants
@theangchen @thgaskell @jaygiang