Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

663 - Add fonts file in Service Worker manifest #38

Merged
merged 1 commit into from
Feb 14, 2025
Merged

663 - Add fonts file in Service Worker manifest #38

merged 1 commit into from
Feb 14, 2025

Conversation

jaygiang
Copy link
Collaborator

@jaygiang jaygiang commented Feb 11, 2025 •
edited
Loading

issue #663
In production mode and network is offline, when a user refreshes browser, the font-family will change

Changes

  • Use CacheFirst in service-worker.js to cache fonts

How to test

  1. run npm run build
  2. run npm run serve
  3. Clear cache in browser
  4. In dev tools > Network > Change network throttling to offline
  5. Refresh browser and font family should remain the same

JCopeland-PIFSC
JCopeland-PIFSC approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@JCopeland-PIFSC JCopeland-PIFSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@thgaskell thgaskell merged commit 11cc654 into main Feb 14, 2025
@thgaskell thgaskell deleted the 633-add-fonts-service-worker branch February 14, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thgaskell thgaskell thgaskell approved these changes

@JCopeland-PIFSC JCopeland-PIFSC JCopeland-PIFSC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaygiang @thgaskell @JCopeland-PIFSC