Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle query string in assetName #82

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Conversation

jimvandervoort
Copy link
Contributor

Noticed this plugin does not handle hashes in sourcemaps correctly. The .map param is added after the query string instead of to the file name. Example:

new MiniCssExtractPlugin({
  filename: '[name].css?[contenthash]',
}),

results in a file name of example.css?query -> example.css?query.map. This should be: example.css?query -> example.css.map?query.

@NMFR NMFR merged commit 64f8309 into NMFR:master Oct 22, 2018
@NMFR
Copy link
Owner

NMFR commented Oct 23, 2018

thx for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants