Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming LoadNLogConfigFromSection to LoadConfigurationFromSection #418

Merged

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Apr 26, 2020

Adjusted #412

Updated example:

                LogManager.Setup()
                    .SetupExtensions(s => s.AutoLoadAssemblies(false))
                    .LoadConfigurationFromSection(config);

Matches: NLog/NLog#3871 for NLog 4.7.1

Allow override of configSection to support "AzureFunctionsJobHost:NLog"

@codecov-io
Copy link

codecov-io commented Apr 26, 2020

Codecov Report

Merging #418 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   82.29%   82.29%           
=======================================
  Files          14       14           
  Lines        1192     1192           
  Branches      195      195           
=======================================
  Hits          981      981           
  Misses        141      141           
  Partials       70       70           
Impacted Files Coverage Δ
...xtensions.Logging/Config/SetupBuilderExtensions.cs 88.88% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd3bcb...f856768. Read the comment docs.

@snakefoot snakefoot changed the title Renaming LoadNLogConfigFromSection to LoadLoadConfigurationFromSection Renaming LoadNLogConfigFromSection to LoadConfigurationFromSection Apr 30, 2020
@snakefoot snakefoot force-pushed the AddNLogLoggingConfigurationFactory branch from b1e3af8 to f856768 Compare May 10, 2020 22:11
@304NotModified 304NotModified merged commit 584cb7a into NLog:master May 11, 2020
@304NotModified
Copy link
Member

(note LoadNLogConfigFromSection was never released)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants