Fixed conflict issue between UseNLog and default log providers #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2019
304NotModified
changed the title
304NotModified
changed the title
|
Thanks @snakefoot ! I will create a new release now. Please confirm that I renamed the PR correctly. |
|
That title also works. Any way no need to hotfix NLog.Web.AspNetCore. Since the bug "only" exists in NLog.Extension.Hosting. |
Thanks, that was indeed my next question ;) |
|
Live! Thanks @snakefoot! |
|
Well kind of embarrassing that I forgot this piece of code, when fixing it in NLog.Web.AspNetCore. But happy it was found and resolved so quickly. Hopefully it has not increased the baldness of too many people pulling their hair. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug introduced with IServiceCollection.Replace. Instead use TryAddEnumerable in UseNLog in NLog.Extension.Hosting.
Resolves #348 by fixing bug introduced with #344.
Same as NLog/NLog.Web#485