Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer SOURCE_DATE_EPOCH over actual time #1238

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

Scrumplex
Copy link
Contributor

@Scrumplex Scrumplex commented Feb 10, 2025

I have noticed that unbound's man pages were not reproducible in NixOS. (See Diffoscope output)

Instead of using the current system time, this patch makes the configure script prefer SOURCE_DATE_EPOCH and otherwise fall back to system time.

ax_build_date_epoch: https://www.gnu.org/software/autoconf-archive/ax_build_date_epoch.html

@Scrumplex Scrumplex changed the title Prefer SOURCE_DATE_EPOCH over actual time" Prefer SOURCE_DATE_EPOCH over actual time Feb 10, 2025
@Scrumplex Scrumplex force-pushed the fix/reproducible-man-page branch from 0000bd7 to 1528a96 Compare February 10, 2025 11:53
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have reproducible build output. The change looks okay.

@wcawijngaards wcawijngaards merged commit d9f1dae into NLnetLabs:master Feb 28, 2025
1 check passed
wcawijngaards added a commit that referenced this pull request Feb 28, 2025
- Merge #1238: Prefer SOURCE_DATE_EPOCH over actual time.
  Add --help output description for the SOURCE_DATE_EPOCH variable.
@wcawijngaards
Copy link
Member

I added an AC_ARG_VAR help string for the variable in the ./configure --help output, that documents the additional functionality introduced by this change. Thank you for the contribution! It is nice to enable reproducible build output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants