Adjust ASPA to new drafts. #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbru
approved these changes
Jun 26, 2023
partim
added a commit
that referenced
this pull request
Jul 5, 2023
Breaking changes * Dropped dependency on _routecore_ again and moved all used types into _rpki-rs_. The new module `resources` contains the AS and IP address resources. The BGPsec key identifier is now an actual type in `crypto::keys`. ([#261]) * Changed the implementation of ASPA objects to conform with version 15 of the profile draft. ([#264], [#265]) * Changed the ASPA RTR PDU to not use the AFI flags any more and always set it to 0. ([#264]) New * Made `rtr::server::NotifyReceiver` public. ([#259]) * Added an exclusion check to SLURM’s router key filters and provided type-specific check methods for the other types. ([#260]) * Added a new module `util::base64` that provides Base 64 encoding of data for various scenarios. ([#263])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the ASPA implementation to the new versions of the Internet drafts.
It changes the ASPA object in the repository module to profile draft version 15. For RTR, it drops the address family attribute but sticks to the PDU format in the old draft and just always sets the AFI flags to zero.
Because the provider AS set is now essentially an encoded version of
SmallAsnSet, the PR also adds a conversion from the former into the latter that omits the unnecessary checks.The code now also enforces a non-empty provider AS set upon parsing.