Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional checks for ASPA validation. #256

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Additional checks for ASPA validation. #256

merged 1 commit into from
Apr 24, 2023

Conversation

partim
Copy link
Member

@partim partim commented Apr 24, 2023

This PR adds three more checks to validation of ASPA objects included in draft-ietf-sidrops-aspa-profile12.

Specifically, it now

  • checks that that the customer AS does not appear in the provider AS set,
  • AS resources of the certificate were not of the "inherit" variant, and
  • IP resources are absent.

@partim partim requested review from DRiKE and timbru April 24, 2023 11:00
timbru
timbru approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@timbru timbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. And indeed, it's good to be strict sooner rather than later.

@partim partim removed the request for review from DRiKE April 24, 2023 11:58
@partim partim merged commit cf30ab5 into main Apr 24, 2023
@partim partim deleted the aspa-validation branch April 24, 2023 11:59
@partim partim mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbru timbru timbru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@partim @timbru