Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor repository and CA code to support BGPsec CSRs. #210

Merged
merged 13 commits into from
Jun 16, 2022
Merged

Refactor repository and CA code to support BGPsec CSRs. #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f065663
Move CSR module under ca.
partim May 31, 2022
c79f3d0
Refactor ... everything to be able to deal with BGPsec CSRs.
partim Jun 2, 2022
3451dbc
Clippy-suggested code improvements.
partim Jun 2, 2022
8299700
Actually disable oid module if bcder is not available.
partim Jun 2, 2022
916b5a0
Enable ca feature for Windows CI.
partim Jun 2, 2022
59c5800
Add missing methods to allow making router certs and add a round-trip…
partim Jun 7, 2022
3de1721
Drop an allow attribute.
partim Jun 7, 2022
55eecc1
This is definitely a breaking PR now.
partim Jun 7, 2022
b3a2e19
Merge branch 'main' into bgpsec-csr
partim Jun 7, 2022
dff1f21
Add function to create extended key usage for router certificates.
Jun 9, 2022
e97b23a
Support serde for PublicKey
Jun 9, 2022
1f38b7a
Use Serial instead of u128 for consistency.
Jun 9, 2022
832a41f
Use TbsCert rather than CertBuilder for now.
Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "rpki"
version = "0.14.3-dev"
version = "0.15.0-dev"
edition = "2018"
authors = ["The NLnet Labs RPKI Team <[email protected]>"]
description = "A library for validating and creating RPKI data."
Expand Down Expand Up @@ -43,7 +43,8 @@ default = []

# Main components of the crate.
ca = [ "repository", "serde-support" ]
repository = [ "bcder", "ring", "untrusted", "routecore/bcder" ]
crypto = [ "bcder", "ring", "untrusted" ]
repository = [ "bcder", "crypto", "routecore/bcder" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If repository includes crypto does it still need bcder? Also, I am not sure why it needs both bcder and routecore/bcder - though that is not related to this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I wonder if we can make repository not require crypto.

I’m not sure if enabling bcder here also enables it for routecore, so I decided to play it safe. This all is going to change eventually with the new way of dealing with features and dependencies stablised in a recent Rust release, but I don’t want to jump MSRVs too quickly.

rrdp = [ "xml", "ring" ]
rtr = [ "futures-util", "tokio", "tokio-stream" ]
slurm = [ "serde-support", "serde_json" ]
Expand All @@ -62,7 +63,7 @@ extra-debug = [ "bcder/extra-debug" ]

# Dummy features for Windows CI runs where we don’t want to have to deal
# with OpenSSL
__windows_ci_all = [ "repository", "rrdp", "rtr", "serde-support", "extra-debug" ]
__windows_ci_all = [ "ca", "rrdp", "rtr", "serde-support", "extra-debug" ]

[[bin]]
name = "readcer"
Expand Down
Loading