Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ManifestHash deal better with possible multiple algorithms. #126

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Make ManifestHash deal better with possible multiple algorithms. #126

merged 2 commits into from
Feb 1, 2021

Conversation

partim
Copy link
Member

@partim partim commented Jan 29, 2021

This PR makes it possible to deal with potentially having multiple digest algorithms in the future. It adds a few functions to DigestAlgorithm and ManifestHash.

DRiKE
DRiKE approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@DRiKE DRiKE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from here

@partim partim merged commit 1a0e77d into master Feb 1, 2021
@partim partim deleted the manifest-hash branch February 1, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DRiKE DRiKE DRiKE approved these changes

@density215 density215 Awaiting requested review from density215

@timbru timbru Awaiting requested review from timbru

@ximon18 ximon18 Awaiting requested review from ximon18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@partim @DRiKE