Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the default RRDP timeout to 300 seconds. #612

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Increase the default RRDP timeout to 300 seconds. #612

merged 2 commits into from
Jul 21, 2021

Conversation

partim
Copy link
Member

@partim partim commented Jul 20, 2021

This also cleans up the awkward Option<Option<Duration>> in the config for this value.

Fixes #595.

@partim partim requested a review from DRiKE July 20, 2021 11:22
DRiKE
DRiKE approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@DRiKE DRiKE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem fine, however the difference between what rrdp_timeout and rrdp_connect_timeout exactly affect is not quite clear from the code/comments itself (though the man page explains the difference).

@partim partim merged commit 3da492e into main Jul 21, 2021
@partim partim deleted the increase-rrdp-timeout branch July 21, 2021 13:56
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request Aug 23, 2021
@he32
Upgrade routinator to version 0.10.0-rc1.
c280416 
Pkgsrc changes:
 * Re-compute checksums

Upstream changes:

Released 2021-08-23

No changes since 0.10.0-rc3.

Released 2021-08-02.

New

* Strict checking for address and prefix lengths in certificates, and for
  prefix and max-length in ROAs. (via [rpki #154], based on an error report by
  [@job])

[rpki #154]: NLnetLabs/rpki-rs#154
[@job]: https://github.com/job

Released 2021-07-27.

Bug Fixes

* Fix the missing line feed in the summary output format. ([#625])
* The RTR server now returns the correct PDU as a cache reset response,
  which is returned when the server cannot provide a delta update to a
  client. Previously, a broken End of Data PDU was returned.
  (Via [rpki #151].)
* Make parsing of local exception files much more strict to avoid introducing
  illegal VRPs into the data set. Parsing will now fail if any aspect of a
  prefix or prefix assertion is incorrect. This includes a non-zero host
  portion of a prefix. ([#627])

[#625]: NLnetLabs/routinator#625
[#627]: NLnetLabs/routinator#627
[rpki #151]: NLnetLabs/rpki-rs#151

Breaking changes

* Data is now stored directly in the file system again. This returns
  memory consumption to pre-0.9 levels. All improvements to robustness
  have been maintained. ([#590], [#601], [#604])
* The `json` and `jsonext` output formats now include a `metadata` object
  that contains the time the data set was created in the `generated` and
  `generatedTime` fields as Unix and ISO time stamps, respectively.
  ([#605])
* The JSON output of the `validate` command and the of the `/validity`
  HTTP endpoint now include a `generatedTime` field that provides
  the generation time of the data set that was used for validation as an
  ISO time stamp. ([#605])
* The default RRDP timeout (via the `rrdp-timeout` option) has been increased
  to 300 seconds. ([#612])

New

* The maximum over delta steps performed during an update of an RRDP
  repository is now be limited via the `rrdp-max-delta` option. If more
  steps are necessary, the snapshot is used instead. This will improve the
  update times in cases where Routinator isnât running constantly. The
  default limit is 100 steps. ([#615])
* It is now possible to disable the use of the gzip transfer encoding in
  the RRDP client via the new `rrdp-disable-gzip` option. ([#602])
* The start of a validation run is now logged as an info message.  ([#609])
* A reference to the global help appears now at the end of a sub-commandâs
  help message. ([#607])
* A summary of the data set similar to the `summary` output format is now
  logged at log level info at the end of a validation run. ([#617])

Bug Fixes

* Catch and log error output from rsync. ([#577])
* Local exception files that contain prefix assertions with a shorter
  max-length than the prefix length are now rejected instead of adding
  these invalid prefix assertions to the output data set. ([#608])
* The `rrdp-timeout` command line option was setting both the RRDP timeout
  and the RRDP connection timeout. Now the `rrdp-connect-timeout` is
  correctly used for the latter. (Note: The config file was using the correct
  keys.) ([#611])
* Added `--rrdp-fallback-time` option to the command line parser. It was
  documented and supposed to be present previously, but wasnât. ([#614])

Other

* In the JSON metrics for RRDP repositories, the fields `serial`,
  `session`, `delta`, and `snapshotReason` are left out entirely when the
  server reported not changes via a 304 response. ([#613])

[#577]: NLnetLabs/routinator#577
[#590]: NLnetLabs/routinator#590
[#601]: NLnetLabs/routinator#601
[#602]: NLnetLabs/routinator#602
[#604]: NLnetLabs/routinator#604
[#605]: NLnetLabs/routinator#605
[#607]: NLnetLabs/routinator#607
[#608]: NLnetLabs/routinator#608
[#609]: NLnetLabs/routinator#609
[#611]: NLnetLabs/routinator#611
[#612]: NLnetLabs/routinator#612
[#613]: NLnetLabs/routinator#613
[#614]: NLnetLabs/routinator#614
[#615]: NLnetLabs/routinator#615
[#617]: NLnetLabs/routinator#617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DRiKE DRiKE DRiKE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase default RRDP timeout.
2 participants
@partim @DRiKE