Modules #111
Merged
Modules #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bal-e
reviewed
Feb 27, 2025
There was a problem hiding this comment.
This is a huge change, @tertsdiepraam, well done! Modules are going to make Roto even cooler.
Comment on lines
+319
to
323
| } else if self.next_is(Token::Period) { | ||
| let ident = self.identifier()?; | ||
| let span = self.merge_spans(&expr, &ident); | ||
| expr = | ||
| self.spans.add(span, Expr::Access(Box::new(expr), ident)); |
There was a problem hiding this comment.
Quick question: how do you distinguish the expression foo.bar from meaning "field bar of object foo" or "declaration bar in module foo"? Or does Expr::Access work on modules too?
There was a problem hiding this comment.
Ah yeah that's an interesting detail. So a path can be both, but access is always a field. foo.bar is parsed as a path, but (1 + 1).bar is an access. The former is disambiguated by the typechecker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91
To do:
.)todo!s with proper errors and make tests for those errors where necessary.