-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.0.3 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the created check filter config.
…l the matched checks, and won't suffer hopefully from unused-rpmlintrc-filter.
…aised and I don't understand why it happens say on rockylinux:8 but not on centos:8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release contains the following changes:
key: value
in rules instead of requiringkey: [value]
for a single element array.pkg
name when building a single O/S package (the majority case).rpmlint --strict
whenstrict_mode
istrue
andrpmlint
version >= 2 (i.e. still not for the oldest O/S's).rpm_rpmlint_check_filters
to enable certainrpmlint
failures to be ignored.rpmlint
errorE: no-binary
by installing the requiredpython-magic
dependency in the build container.rpmlint
warnings for tags that are not yet supported bycargo-generate-rpm
. The full list of suppresed warnings is:no-buildhost-tag
no-changelogname-tag
no-group-tag
no-packager-tag
no-signature
no-url-tag
rpmlint
errormissing-call-to-chdir-with-chroot
as it only appears to exist on olderrpmlint
versions and was reported as potentially causing false positivesSuccessful test runs can be seen here:
Release checklist:
.github/workflows/pkg.yml
so that instead of referring topkg-rust.yml@vX
it refers topkg-rust.yml@<Git ref of HEAD commit on the TEST branch>
orpkg-rust.yml@<test branch name>
..gihub-testing
repository from the TEST branch tomain
, let's call this the TEST PR.Packaging
workflow run in the TEST PR passes and behaves as desired.main
branch.Packaging
workflow in the TEST repo against themain
branch passes and behaves as desired. If not, repeat steps 4-9 until the new TEST PR passes and behaves as desired.Packaging
workflow in the TEST repo passes against the newly created release tag passes and behaves as desired. If not, delete the release tag in the TEST repo and repeat steps 4-11 until the new TEST PR passes and behaves as desired.main
branch..github/workflows/pkg.yml
in themain
branch of the TEST repo to refer again to@vX
.Packaging
action in the TEST repo against themain
branch passes and works as desired.