Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.3 #42

Merged
merged 28 commits into from
Nov 24, 2022
Merged

v5.0.3 #42

merged 28 commits into from
Nov 24, 2022

Conversation

ximon18
Copy link
Member

@ximon18 ximon18 commented Nov 23, 2022

This release contains the following changes:

  • Permit key: value in rules instead of requiring key: [value] for a single element array.
  • Don't require a pkg name when building a single O/S package (the majority case).
  • Correctly enable failing on DEB lint errors on newer O/S's (e.g. Jammy), as already happens on older O/S's.
  • Enable rpmlint --strict when strict_mode is true and rpmlint version >= 2 (i.e. still not for the oldest O/S's).
  • Added new build rule key rpm_rpmlint_check_filters to enable certain rpmlint failures to be ignored.
  • Prevent rpmlint error E: no-binary by installing the required python-magic dependency in the build container.
  • Suppress rpmlint warnings for tags that are not yet supported by cargo-generate-rpm. The full list of suppresed warnings is:
    • no-buildhost-tag
    • no-changelogname-tag
    • no-group-tag
    • no-packager-tag
    • no-signature
    • no-url-tag
  • Suppress rpmlint error missing-call-to-chdir-with-chroot as it only appears to exist on older rpmlint versions and was reported as potentially causing false positives

Successful test runs can be seen here:

Release checklist:

  • 1. Create a branch in the RELEASE repo, let's call this the RELEASE branch.
  • 2. Change RPM_MACROS_URL in the workflow to point to the new RELEASE branch.
  • 3. Create a PR in the RELEASE repo for the RELEASE branch.
  • 4. Create a matching branch in the TEST repo, let's call this the TEST branch.
  • 5. Make the desired changes to the RELEASE branch.
  • 6. In the TEST branch modify .github/workflows/pkg.yml so that instead of referring to pkg-rust.yml@vX it refers to pkg-rust.yml@<Git ref of HEAD commit on the TEST branch> or pkg-rust.yml@<test branch name>.
  • 7. Create a PR in the .gihub-testing repository from the TEST branch to main, let's call this the TEST PR.
  • 8. Repeat steps 4 and 5 until the the Packaging workflow run in the TEST PR passes and behaves as desired.
  • 9. Merge the TEST PR to the main branch.
  • 10. Verify that the automatically invoked run of the Packaging workflow in the TEST repo against the main branch passes and behaves as desired. If not, repeat steps 4-9 until the new TEST PR passes and behaves as desired.
  • 11. Create a release tag in the TEST repo with the same release tag as will be used in the RELEASE repo, e.g. v1.2.3. Note: Remember to respect semantic versioning, i.e. if the changes being made are not backward compatible you will need to bump the MAJOR version (in MAJOR.MINOR.PATCH) and any workflows that invoke the reusable workflow will need to be manually edited to refer to the new MAJOR version.
  • 12. Verify that the automatically invoked run of the Packaging workflow in the TEST repo passes against the newly created release tag passes and behaves as desired. If not, delete the release tag in the TEST repo and repeat steps 4-11 until the new TEST PR passes and behaves as desired.
  • 13. Merge the RELEASE PR to the main branch.
  • 14. Change RPM_MACROS_URL in the workflow to point to vX.Y.Z tag (that you are about to create).
  • 15. Create the new release vX.Y.Z tag in the RELEASE repo.
  • 16. Update the vX tag in the RELEASE repo to point to the new vX.Y.Z tag.
  • 17. Edit .github/workflows/pkg.yml in the main branch of the TEST repo to refer again to @vX.
  • 18. Verify that the Packaging action in the TEST repo against the main branch passes and works as desired.
  • 19. (optional) If the MAJOR version was changed, update affected repositories that use the reusable workflow to use the new MAJOR version, including adjusting to any breaking changes introduced by the MAJOR version change.

@ximon18 ximon18 added the enhancement New feature or request label Nov 23, 2022
…l the matched checks, and won't suffer hopefully from unused-rpmlintrc-filter.
…aised and I don't understand why it happens say on rockylinux:8 but not on centos:8.
@ximon18 ximon18 merged commit 7a1d754 into main Nov 24, 2022
@ximon18 ximon18 deleted the v5.0.3 branch November 24, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant