Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a logo to the README #663

Merged
merged 2 commits into from
Sep 21, 2024
Merged

adds a logo to the README #663

merged 2 commits into from
Sep 21, 2024

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented Sep 10, 2024

I generated a simple logo for the template, hope you like it.

@vedran-kasalica
Copy link
Member

vedran-kasalica commented Sep 10, 2024

It looks great! I did a bit of manual retouching, @egpbos what do you think about it? python-template copy
I still want to fix the issue with the sneak head and the printer cover.

@egpbos
Copy link
Member Author

egpbos commented Sep 10, 2024

Ha nice, that tongue was bugging me as well :D Let's keep the snake head as it is, that one looks more natural/smooth than the broken tongue. Please commit your logo version to this branch.

@vedran-kasalica
Copy link
Member

Ha nice, that tongue was bugging me as well :D Let's keep the snake head as it is, that one looks more natural/smooth than the broken tongue. Please commit your logo version to this branch.

I pushed the logo, but I also made a newer version with the head "fixed" (not committed). It looks a bit less AI-generated, not sure if that's the look we are going for.
logo-new

@egpbos
Copy link
Member Author

egpbos commented Sep 10, 2024

I love it, thanks, please push it!

@fdiblen
Copy link
Member

fdiblen commented Sep 10, 2024

Our contributing guidelines has the following

(important) announce your plan to the rest of the community before you start working. This announcement should be in the form of a (new) issue;
(important) wait until some kind of consensus is reached about your idea being a good idea;

I suggest we discuss the further changes before creating PRs.

@vedran-kasalica
Copy link
Member

I pushed the final version! I also opened an issue #664, related to this PR.

@vedran-kasalica vedran-kasalica linked an issue Sep 10, 2024 that may be closed by this pull request
1 task
@egpbos
Copy link
Member Author

egpbos commented Sep 10, 2024

Off-topic, but since you brought it up @fdiblen: I think those guidelines are overly strict :) This was not a super high-effort PR. I think discussion could have just taken place here as well, let's not overcomplicate things when it's not necessary.

On-topic: I put some more motivation for this PR in #664, please check it out if you are unsure of the point of this PR and feel free to discuss there before reviewing the PR itself.

@fdiblen
Copy link
Member

fdiblen commented Sep 10, 2024

Off-topic, but since you brought it up @fdiblen: I think those guidelines are overly strict :) This was not a super high-effort PR. I think discussion could have just taken place here as well, let's not overcomplicate things when it's not necessary.

On-topic: I put some more motivation for this PR in #664, please check it out if you are unsure of the point of this PR and feel free to discuss there before reviewing the PR itself.

My point is more about compliance than being strict or amount of work. Let's discuss these in-person and adjust the guidelines to make the team more confortable and collaborate more efficiently. 🙂

Also, thanks for creating the issue and starting the discussion. 🙏

@bouweandela
Copy link
Member

Is the snake referring to Python? In that case it might be nice to use a python instead of a cobra.

@vedran-kasalica
Copy link
Member

Is the snake referring to Python? In that case it might be nice to use a python instead of a cobra.

That's a reasonable point, but similarly we can also ask what the printer with a tie represents. Imo there is a certain charm to an AI-generated logo that vaguely depicts the idea behind the project.

On an unrelated note, I was curious about the Photoshop warping feature, so I just played with it a bit, but it is hard to make the body thick without losing quality or spending too much time on it. I am done editing the figure, l promise :)

logo-python

@egpbos
Copy link
Member Author

egpbos commented Sep 12, 2024

We don't have to use a python, other snakes are also ecosystem compliant ;) See e.g. anaconda (which is a boa), mamba (a venomous snake, completely different taxonomic family).

In fact, the cobra can "change shape" a bit (flaring its ... flaps?), which could be seen as a symbol of instantiating a template.

Diving into this rabbit hole, I googled for snakes that can change shape or color.

These could also serve as inspiration for #666.

@egpbos
Copy link
Member Author

egpbos commented Sep 21, 2024

Updated with the final version pasted in @vedran-kasalica's last message. Squashed the commits into two to keep the history clean. We had informal approvals and no objections, so I think we can merge now.

@egpbos
Copy link
Member Author

egpbos commented Sep 21, 2024

Rebased on main.

@egpbos egpbos merged commit fe67a51 into main Sep 21, 2024
18 checks passed
@egpbos egpbos deleted the logo branch September 21, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a logo
4 participants