Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpp issues and requirements #183

Closed
wants to merge 8 commits into from
Closed

mpp issues and requirements #183

wants to merge 8 commits into from

Conversation

martvanrijthoven
Copy link
Collaborator

  • swap mpp_y, mpp_x to mpp_x, mpp_y
  • return mpp_x for scaling
  • lowered requirements to be compatible with other packages

@jonasteuwen
Copy link
Contributor

Why do you take mpp = mpp_x? And not maybe like min[mpp_x, mpp_y] or the average we took before?

@jonasteuwen
Copy link
Contributor

Thank you for the fix. Could you revert to using mpp_x rather than (mpp_x + mpp_y)/2? I believe this is only an issue in your viewer, or is there a grander idea why mpp_x would be better than mpp_y (or anything else?)

@jonasteuwen jonasteuwen mentioned this pull request Oct 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martvanrijthoven @jonasteuwen