Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/mypy strict #172

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Improvement/mypy strict #172

merged 3 commits into from
Oct 9, 2023

Conversation

jonasteuwen
Copy link
Contributor

dlup now passed mypy strictly.

EricMarcus-ai
EricMarcus-ai approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@EricMarcus-ai EricMarcus-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good mypy typing updates. lgtm

@jonasteuwen jonasteuwen merged commit 19311c4 into main Oct 9, 2023
8 checks passed
@jonasteuwen jonasteuwen deleted the improvement/mypy-strict branch October 9, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricMarcus-ai EricMarcus-ai EricMarcus-ai approved these changes

Assignees
No one assigned
Labels
ci python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasteuwen @EricMarcus-ai