Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage #165

Merged
merged 13 commits into from
Sep 28, 2023
Merged

Increase test coverage #165

merged 13 commits into from
Sep 28, 2023

Conversation

jonasteuwen
Copy link
Contributor

This branch improves the test coverage of dlup

EricMarcus-ai
EricMarcus-ai reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@EricMarcus-ai EricMarcus-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements to the testing. Some minor comments.

dlup/backends/common.py Outdated Show resolved Hide resolved
dlup/experimental_backends/pyvips_backend.py Show resolved Hide resolved
tests/backends/test_common.py Outdated Show resolved Hide resolved
tests/backends/test_common.py Show resolved Hide resolved
tests/backends/test_tifffile_backend.py Show resolved Hide resolved
tests/test_cli.py Show resolved Hide resolved
EricMarcus-ai
EricMarcus-ai approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@EricMarcus-ai EricMarcus-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasteuwen jonasteuwen merged commit ded8a71 into main Sep 28, 2023
8 checks passed
@jonasteuwen jonasteuwen deleted the improve-coverage branch September 28, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricMarcus-ai EricMarcus-ai EricMarcus-ai approved these changes

@martvanrijthoven martvanrijthoven Awaiting requested review from martvanrijthoven

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasteuwen @EricMarcus-ai