Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-static and kt sampling #280

Merged
merged 10 commits into from
Jul 3, 2024
Merged

Add non-static and kt sampling #280

merged 10 commits into from
Jul 3, 2024

Conversation

georgeyiasemis
Copy link
Contributor

This PR introduces:

  • kt sampling mask functions: KtGaussian1DMaskFunc, KtRadialMaskFunc, KtUniformMaskFunc,
  • Non-static sampling (dynamic/multislice) dicitated by the MaskFuncMode which can be STATIC, MULTISLICE, DYNAMIC
  • Corresponding tests

@georgeyiasemis georgeyiasemis self-assigned this Jun 27, 2024
@georgeyiasemis georgeyiasemis mentioned this pull request Jun 27, 2024
Closed
6 tasks
@georgeyiasemis georgeyiasemis added this to the v2.1.0 milestone Jun 27, 2024
jonasteuwen
jonasteuwen reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

direct/common/subsample_config.py Show resolved Hide resolved
direct/types.py Show resolved Hide resolved
direct/utils/__init__.py Outdated Show resolved Hide resolved
direct/common/subsample.py Outdated Show resolved Hide resolved
@georgeyiasemis georgeyiasemis linked an issue Jul 2, 2024 that may be closed by this pull request
v2.1.0 tracking #281
Closed
6 tasks
@jonasteuwen jonasteuwen merged commit e9e63d6 into main Jul 3, 2024
10 checks passed
@georgeyiasemis georgeyiasemis deleted the feature/kt-sampling branch July 3, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasteuwen jonasteuwen jonasteuwen left review comments

Assignees

@georgeyiasemis georgeyiasemis

Labels
python
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

v2.1.0 tracking
2 participants
@georgeyiasemis @jonasteuwen